Pushed at 93a98df2609763cc162191bd5395617a621747fe -----Original Message----- From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Eric Jin Sent: Friday, September 20, 2019 11:10 AM To: Liu, XianhuiX <xianhuix....@intel.com>; devel@edk2.groups.io Cc: Oleksiy <oleks...@ami.com>; Supreeth Venkatesh <supreeth.venkat...@arm.com> Subject: Re: [edk2-devel] [edk2-test][Patch] uefi-sct/SctPkg: Fix invalid attribute combination
Reviewed-by: Eric Jin <eric....@intel.com> -----Original Message----- From: Liu, XianhuiX <xianhuix....@intel.com> Sent: Wednesday, September 18, 2019 10:38 AM To: devel@edk2.groups.io Cc: Oleksiy <oleks...@ami.com>; Supreeth Venkatesh <supreeth.venkat...@arm.com>; Jin, Eric <eric....@intel.com> Subject: [edk2-test][Patch] uefi-sct/SctPkg: Fix invalid attribute combination REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1942 avoid using EFI_VARIABLE_RUNTIME_ACCESS without EFI_VARIABLE_BOOTSERVICE_ACCESS in AttrArray. Cc: Oleksiy <oleks...@ami.com> Cc: Supreeth Venkatesh <supreeth.venkat...@arm.com> Cc: Eric Jin <eric....@intel.com> Signed-off-by: xianhui liu <xianhuix....@intel.com> --- .../BlackBoxTest/AuthVariableServicesBBTestConformance.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/VariableServices/BlackBoxTest/AuthVariableServicesBBTestConformance.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/VariableServices/BlackBoxTest/AuthVariableServicesBBTestConformance.c index a1d1c4c3..23b00e35 100644 --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/VariableServices/BlackBoxTest/AuthVariableServicesBBTestConformance.c +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/VariableServices +++ /BlackBoxTest/AuthVariableServicesBBTestConformance.c @@ -1,7 +1,7 @@ /** @file Copyright 2006 - 2012 Unified EFI, Inc.<BR> - Copyright (c) 2010 - 2018, Intel Corporation. All rights reserved.<BR> + Copyright (c) 2010 - 2019, Intel Corporation. All rights + reserved.<BR> This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License @@ -160,19 +160,16 @@ AuthVariableDERConfTest ( // For 1 attribute. // EFI_VARIABLE_NON_VOLATILE, - EFI_VARIABLE_RUNTIME_ACCESS, EFI_VARIABLE_BOOTSERVICE_ACCESS, EFI_VARIABLE_TIME_BASED_AUTHENTICATED_WRITE_ACCESS, // // For 2 attributes. // - EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_RUNTIME_ACCESS, EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS, EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_TIME_BASED_AUTHENTICATED_WRITE_ACCESS, EFI_VARIABLE_RUNTIME_ACCESS | EFI_VARIABLE_BOOTSERVICE_ACCESS, - EFI_VARIABLE_RUNTIME_ACCESS | EFI_VARIABLE_TIME_BASED_AUTHENTICATED_WRITE_ACCESS, EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_TIME_BASED_AUTHENTICATED_WRITE_ACCESS, @@ -180,7 +177,6 @@ AuthVariableDERConfTest ( // For 3 attributes. // EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_RUNTIME_ACCESS | EFI_VARIABLE_BOOTSERVICE_ACCESS, - EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_RUNTIME_ACCESS | EFI_VARIABLE_TIME_BASED_AUTHENTICATED_WRITE_ACCESS, EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_TIME_BASED_AUTHENTICATED_WRITE_ACCESS, EFI_VARIABLE_RUNTIME_ACCESS | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_TIME_BASED_AUTHENTICATED_WRITE_ACCESS, -- 2.14.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#47811): https://edk2.groups.io/g/devel/message/47811 Mute This Topic: https://groups.io/mt/34185463/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
