On Thu, Sep 19, 2019 at 02:16:44PM +0000, Gao, Liming wrote: > Leif: > > > -----Original Message----- > > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > > Sent: Thursday, September 19, 2019 5:18 PM > > To: Gao, Liming <liming....@intel.com> > > Cc: Gao, Zhichao <zhichao....@intel.com>; devel@edk2.groups.io; Andrew Fish > > <af...@apple.com>; Laszlo Ersek <ler...@redhat.com>; > > Kinney, Michael D <michael.d.kin...@intel.com>; Ni, Ray <ray...@intel.com>; > > Ard Biesheuvel <ard.biesheu...@linaro.org> > > Subject: Re: [PATCH] Edk2: Add Zhichao as the maintainer for shellbin relase > > > > I have no objection to this addition, but I do have two questions - and > > really I realise this is a follow-on for 81a8a52a6bb21 ("ShellBinPkg: > > Remove ShellBinPkg"): > > > > 1) Since ShellBinPkg no longer exists, what is the intent of listing > > this in the Maintainers.txt file? Generally, this is so that people > > know who to Cc: on patches - but there will not be any patches here. > > Here is the info who can be contacted to generate the binary files > for the quarter stable tag.
I agree this is important to keep somewhere. But I am unsure if Maintainers.txt is the location for that. Clearly it was when ShellBinPkg existed, but I am not sure now. And yes, this is something I should have realised when ShellBinPkg was removed - but I didn't at that point. So there is no need to hold back this patch. But I think it would make possibly more sense to add this information either into a ShellPkg/Readme.md or the wiki. If we keep the information in Maintainers.txt, I would suggest creating a new section below "EDK II Releases:" with a W: entry pointing somewhere. Best Regards, Leif > > 2) If Zhichao is now responsible for this, should Jaben and Ray still > > be listed? > > > I think Jaben and Ray can be removed. > > Thanks > Liming > > Best Regards, > > > > Leif > > > > On Thu, Sep 19, 2019 at 05:58:16AM +0000, Gao, Liming wrote: > > > Reviewed-by: Liming Gao <liming....@intel.com> > > > > > > >-----Original Message----- > > > >From: Gao, Zhichao > > > >Sent: Thursday, September 19, 2019 1:46 PM > > > >To: devel@edk2.groups.io > > > >Cc: Andrew Fish <af...@apple.com>; Laszlo Ersek <ler...@redhat.com>; Leif > > > >Lindholm <leif.lindh...@linaro.org>; Kinney, Michael D > > > ><michael.d.kin...@intel.com>; Ni, Ray <ray...@intel.com>; Ard Biesheuvel > > > ><ard.biesheu...@linaro.org>; Gao, Liming <liming....@intel.com> > > > >Subject: [PATCH] Edk2: Add Zhichao as the maintainer for shellbin relase > > > > > > > >Zhichao is responsible for the IA32 and X64 ARCH shell binary generation. > > > > > > > >Cc: Andrew Fish <af...@apple.com> > > > >Cc: Laszlo Ersek <ler...@redhat.com> > > > >Cc: Leif Lindholm <leif.lindh...@linaro.org> > > > >Cc: Michael D Kinney <michael.d.kin...@intel.com> > > > >Cc: Ray Ni <ray...@intel.com> > > > >Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> > > > >Cc: Liming Gao <liming....@intel.com> > > > >Signed-off-by: Zhichao Gao <zhichao....@intel.com> > > > >--- > > > > Maintainers.txt | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > > >diff --git a/Maintainers.txt b/Maintainers.txt > > > >index dcf81c737a..a0121123ec 100644 > > > >--- a/Maintainers.txt > > > >+++ b/Maintainers.txt > > > >@@ -426,6 +426,7 @@ Maintainers for stable Shell binaries generation > > > > when need to publish Shell binaries with edk2 release: > > > > M: Jaben Carsey <jaben.car...@intel.com> (Ia32/X64) > > > > M: Ray Ni <ray...@intel.com> (Ia32/X64) > > > >+M: Zhichao Gao <zhichao....@intel.com> (Ia32/X64) > > > > M: Leif Lindholm <leif.lindh...@linaro.org> (ARM/AArch64) > > > > M: Ard Biesheuvel <ard.biesheu...@linaro.org> (ARM/AArch64) > > > > > > > >-- > > > >2.21.0.windows.1 > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#47600): https://edk2.groups.io/g/devel/message/47600 Mute This Topic: https://groups.io/mt/34196896/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
