On Thu, Sep 19, 2019 at 01:37:40PM +0300, Ard Biesheuvel wrote: > On Thu, 19 Sep 2019 at 13:34, Baptiste Gerondeau > <baptiste.gerond...@linaro.org> wrote: > >> In any case, I'd strongly prefer it if the .S and .asm files produced > >> identical object code, so please apply the same changes to the sibling > >> .S files as well, please (but only the ones that are really required > >> when building it in ARM mode) > > > > > > ACK ! Will mirror changes to asm on S files (on separate commit, right ?) > > I'm only touching the files VS2019 as a problem with on the ARM > > build anyways (this is what you meant by "really required" right > > ?) > > I mean that I'd prefer to assemble the .asm files in ARM mode, > especially since I am not convinced that the startup code we have is > guaranteed to switch into the right mode after the CPU comes out of > reset in ARM mode.
That could be resolved with a trivial branch at that point (or just forcing ARM for the whole entry file) though. But I'm OK with forcing ARM for all .asm files for now. / Leif -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#47593): https://edk2.groups.io/g/devel/message/47593 Mute This Topic: https://groups.io/mt/34187299/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-