Reviewed-by: Chasel Chiu <chasel.c...@intel.com>
> -----Original Message----- > From: Kubacki, Michael A > Sent: Tuesday, August 27, 2019 2:48 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel <chasel.c...@intel.com>; Chaganty, Rangasai V > <rangasai.v.chaga...@intel.com> > Subject: [edk2-platforms][PATCH V3 1/2] CoffeelakeSiliconPkg: Fix GCC Build > Failures > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2124 > > Fixes build failures on GCC7.3.0. Tested on Ubuntu 18.04.1 LTS. > > Cc: Chasel Chiu <chasel.c...@intel.com> > Cc: Sai Chaganty <rangasai.v.chaga...@intel.com> > Signed-off-by: Michael Kubacki <michael.a.kuba...@intel.com> > --- > > Silicon/Intel/CoffeelakeSiliconPkg/Pch/Include/ConfigBlock/HdAudioConfig.h > | 2 ++ > Silicon/Intel/CoffeelakeSiliconPkg/Pch/Include/Library/GpioLib.h > | 1 + > > Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiPchPolicyLib/PeiPchPolicyLi > b.c | 2 -- > Silicon/Intel/CoffeelakeSiliconPkg/SystemAgent/SaInit/Dxe/SaInitDxe.c > | 1 + > 4 files changed, 4 insertions(+), 2 deletions(-) > > diff --git > a/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Include/ConfigBlock/HdAudioConfi > g.h > b/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Include/ConfigBlock/HdAudioConfi > g.h > index a810d4f1fc..e2c8730f38 100644 > --- > a/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Include/ConfigBlock/HdAudioConfi > g.h > +++ b/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Include/ConfigBlock/HdAudio > +++ Config.h > @@ -9,7 +9,9 @@ > #ifndef _HDAUDIO_CONFIG_H_ > #define _HDAUDIO_CONFIG_H_ > > +#include <ConfigBlock.h> > #include <PchHda.h> > +#include <Uefi.h> > > #define HDAUDIO_PREMEM_CONFIG_REVISION 1 #define > HDAUDIO_CONFIG_REVISION 2 diff --git > a/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Include/Library/GpioLib.h > b/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Include/Library/GpioLib.h > index 25def24fca..ff76e7c60f 100644 > --- a/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Include/Library/GpioLib.h > +++ b/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Include/Library/GpioLib.h > @@ -11,6 +11,7 @@ > #define _GPIO_LIB_H_ > > #include <GpioConfig.h> > +#include <Uefi.h> > > #define GPIO_NAME_LENGTH_MAX 32 > > diff --git > a/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiPchPolicyLib/PeiPchPolic > yLib.c > b/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiPchPolicyLib/PeiPchPolic > yLib.c > index 2a1da20667..ece0be8158 100644 > --- > a/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiPchPolicyLib/PeiPchPolic > yLib.c > +++ b/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiPchPolicyLib/Pei > +++ PchPolicyLib.c > @@ -353,10 +353,8 @@ LoadLanConfigDefault ( > ) > { > PCH_LAN_CONFIG *LanConfig; > - UINT16 LpcDid; > > LanConfig = ConfigBlockPointer; > - LpcDid = PchGetLpcDid (); > > DEBUG ((DEBUG_INFO, "LanConfig->Header.GuidHob.Name = %g\n", > &LanConfig->Header.GuidHob.Name)); > DEBUG ((DEBUG_INFO, "LanConfig->Header.GuidHob.Header.HobLength = > 0x%x\n", LanConfig->Header.GuidHob.Header.HobLength)); > diff --git > a/Silicon/Intel/CoffeelakeSiliconPkg/SystemAgent/SaInit/Dxe/SaInitDxe.c > b/Silicon/Intel/CoffeelakeSiliconPkg/SystemAgent/SaInit/Dxe/SaInitDxe.c > index d646e60618..e6980f9a65 100644 > --- a/Silicon/Intel/CoffeelakeSiliconPkg/SystemAgent/SaInit/Dxe/SaInitDxe.c > +++ b/Silicon/Intel/CoffeelakeSiliconPkg/SystemAgent/SaInit/Dxe/SaInitDx > +++ e.c > @@ -41,6 +41,7 @@ SaInitEntryPointDxe ( > SaInitEntryPoint (); > > Status = SaAcpiInit (ImageHandle); > + ASSERT_EFI_ERROR (Status); > > /// > /// Create PCI Enumeration Completed callback for SA > -- > 2.16.2.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#46401): https://edk2.groups.io/g/devel/message/46401 Mute This Topic: https://groups.io/mt/33037332/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
