Hi All, This patch has little impact. So I think it's ok to be checked in before code freeze.
Thanks, Shenglei > -----Original Message----- > From: Wang, Jian J > Sent: Friday, August 16, 2019 3:18 PM > To: Zhang, Shenglei <shenglei.zh...@intel.com>; devel@edk2.groups.io > Cc: Ye, Ting <ting...@intel.com> > Subject: RE: [PATCH 1/1] CryptoPkg: Fix coding style > > > Reviewed-by: Jian J Wang <jian.j.w...@intel.com> > > > > -----Original Message----- > > From: Zhang, Shenglei > > Sent: Friday, August 16, 2019 2:54 PM > > To: devel@edk2.groups.io > > Cc: Wang, Jian J <jian.j.w...@intel.com>; Ye, Ting <ting...@intel.com> > > Subject: [PATCH 1/1] CryptoPkg: Fix coding style > > > > Update attribute "Out" to "out". > > The original "Out" can not pass ECC check. > > > > Cc: Jian Wang <jian.j.w...@intel.com> > > Cc: Ting Ye <ting...@intel.com> > > Signed-off-by: Shenglei Zhang <shenglei.zh...@intel.com> > > --- > > CryptoPkg/Library/BaseCryptLib/Kdf/CryptHkdf.c | 2 +- > > CryptoPkg/Library/BaseCryptLib/Kdf/CryptHkdfNull.c | 2 +- > > CryptoPkg/Include/Library/BaseCryptLib.h | 2 +- > > 3 files changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/CryptoPkg/Library/BaseCryptLib/Kdf/CryptHkdf.c > > b/CryptoPkg/Library/BaseCryptLib/Kdf/CryptHkdf.c > > index f0fcef211d3f..3a827dadfcbd 100644 > > --- a/CryptoPkg/Library/BaseCryptLib/Kdf/CryptHkdf.c > > +++ b/CryptoPkg/Library/BaseCryptLib/Kdf/CryptHkdf.c > > @@ -19,7 +19,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > > @param[in] SaltSize Salt size in bytes. > > @param[in] Info Pointer to the application specific info. > > @param[in] InfoSize Info size in bytes. > > - @param[Out] Out Pointer to buffer to receive hkdf value. > > + @param[out] Out Pointer to buffer to receive hkdf value. > > @param[in] OutSize Size of hkdf bytes to generate. > > > > @retval TRUE Hkdf generated successfully. > > diff --git a/CryptoPkg/Library/BaseCryptLib/Kdf/CryptHkdfNull.c > > b/CryptoPkg/Library/BaseCryptLib/Kdf/CryptHkdfNull.c > > index 73deb5bc3614..19d795a4cc16 100644 > > --- a/CryptoPkg/Library/BaseCryptLib/Kdf/CryptHkdfNull.c > > +++ b/CryptoPkg/Library/BaseCryptLib/Kdf/CryptHkdfNull.c > > @@ -18,7 +18,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > > @param[in] SaltSize Salt size in bytes. > > @param[in] Info Pointer to the application specific info. > > @param[in] InfoSize Info size in bytes. > > - @param[Out] Out Pointer to buffer to receive hkdf value. > > + @param[out] Out Pointer to buffer to receive hkdf value. > > @param[in] OutSize Size of hkdf bytes to generate. > > > > @retval TRUE Hkdf generated successfully. > > diff --git a/CryptoPkg/Include/Library/BaseCryptLib.h > > b/CryptoPkg/Include/Library/BaseCryptLib.h > > index da32bb2444fd..8fe303a0b390 100644 > > --- a/CryptoPkg/Include/Library/BaseCryptLib.h > > +++ b/CryptoPkg/Include/Library/BaseCryptLib.h > > @@ -3135,7 +3135,7 @@ RandomBytes ( > > @param[in] SaltSize Salt size in bytes. > > @param[in] Info Pointer to the application specific info. > > @param[in] InfoSize Info size in bytes. > > - @param[Out] Out Pointer to buffer to receive hkdf value. > > + @param[out] Out Pointer to buffer to receive hkdf value. > > @param[in] OutSize Size of hkdf bytes to generate. > > > > @retval TRUE Hkdf generated successfully. > > -- > > 2.18.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#45804): https://edk2.groups.io/g/devel/message/45804 Mute This Topic: https://groups.io/mt/32895950/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
