Hi Vitaly, Thanks for the contribution. I see you are using _MSC_VER. The rest of Base.h uses _MSC_EXTENSIONs and only if that is defined is _MSC_VER used and _MSC_VER is only used if a specific version value check is required. What version of VS introduced this feature? We can define this macro to nothing of the version is too small. Also, is the mapping for both GCC and XCODE5 the same?
For the next version of this patch, can you use the ‘git send-email’ feature instead of attaching a patch file? A couple useful links: https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers Thanks, Mike From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of via Groups.Io Sent: Monday, August 12, 2019 3:06 AM To: devel@edk2.groups.io Subject: [edk2-devel] [PATCH] MdePkg: Add STATIC_ASSERT macro Implements https://bugzilla.tianocore.org/show_bug.cgi?id=2048. Best regards, Vitaly Cheptsov -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#45467): https://edk2.groups.io/g/devel/message/45467 Mute This Topic: https://groups.io/mt/32841448/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
