Hi Gary, I found that the regression was introduced at commit
https://github.com/tianocore/edk2-platforms/commit/6738c654c8eddccc2a1230a4541bc2cb74c10ea5 The issue is in Vlv2Tbl2DevicePkg/PlatformSetupDxe/PlatformSetupDxe.c The call to SetupInfo() was inadvertently removed from SystemConfigExtractConfig() when that function was simplified due to the varstore type change to efivarstore. I have verified that adding back the call to SetupInfo() restores the missing values in those setup forms. I have pushed your series as: 812b291c55..603ec40dbb I will send patch review for the regression later today. Mike > -----Original Message----- > From: Kinney, Michael D > Sent: Thursday, August 8, 2019 8:04 AM > To: devel@edk2.groups.io; g...@suse.com; Kinney, > Michael D <michael.d.kin...@intel.com> > Cc: Qian, Yi <yi.q...@intel.com>; Sun, Zailiang > <zailiang....@intel.com> > Subject: RE: [edk2-devel] [edk2-platforms] [PATCH v2 > 0/6] Fix the boot order, SMBIOS, and capsule GUIDs of > Minnowboard > > Hi Gary, > > Thanks for the additional information. > I will investigate when it was introduced. > > The patch series looks good. > > Reviewed-by: Michael D Kinney > <michael.d.kin...@intel.com> > > Mike > > > -----Original Message----- > > From: devel@edk2.groups.io > > [mailto:devel@edk2.groups.io] On Behalf Of Gary Lin > > Sent: Thursday, August 8, 2019 1:08 AM > > To: devel@edk2.groups.io; Kinney, Michael D > > <michael.d.kin...@intel.com> > > Cc: Qian, Yi <yi.q...@intel.com>; Sun, Zailiang > > <zailiang....@intel.com> > > Subject: Re: [edk2-devel] [edk2-platforms] [PATCH v2 > 0/6] Fix the boot > > order, SMBIOS, and capsule GUIDs of Minnowboard > > > > On Thu, Aug 08, 2019 at 07:26:04AM +0000, Michael D > Kinney wrote: > > > Hi Gary, > > > > > Hi Michael, > > > > > Thank you for these patches. > > > > > > I am seeing one behavior change in the setup forms. > > > The following 2 forms are missing information that > > used to be filled > > > in. I will help look into this tomorrow. > > > > > > 1) Device Manager -> System Setup -> Main > > > > > > 2) Device Manager -> System Setup -> Main -> > Platform > > Information > > > > > I built another firmware without my patches and those > information were > > still missing, so the bug is probably introduced by > other patch. > > > > Thanks, > > > > Gary Lin > > > > > Best regards, > > > > > > Mike > > > > > > > -----Original Message----- > > > > From: Gary Lin [mailto:g...@suse.com] > > > > Sent: Tuesday, July 30, 2019 1:16 AM > > > > To: devel@edk2.groups.io > > > > Cc: Sun, Zailiang <zailiang....@intel.com>; Qian, > > Yi > > > > <yi.q...@intel.com>; Kinney, Michael D > > <michael.d.kin...@intel.com> > > > > Subject: [edk2-platforms] [PATCH v2 0/6] Fix the > > boot order, SMBIOS, > > > > and capsule GUIDs of Minnowboard > > > > > > > > After switching to MdeModulePkg BdsDxe, the boot > > option created by > > > > OS was always put at the end of BootOrder after > > reboot. Besides, the > > > > PXE boot options were always the first boot > > options. > > > > > > > > The 1st to 3rd patches fix the priority of boot > > options and stop > > > > sorting the boot options after the first boot. > > > > The missing BootManagerMenuApp is also added > back. > > > > > > > > The 4th patch cleans up PlatformBootOption.c to > > remove the unused > > > > variables and function. > > > > > > > > The 5th patch adds some missing bits of BIOS > > Characteristics > > > > Extension in SMBIOS, so that fwupd can detect the > > system correctly. > > > > > > > > The 6th patch converts the device GUIDs in > > metainfo.xml to lowercase > > > > to be compatible with LVFS/fwupd. > > > > > > > > The patches are also available in my github > branch: > > > > https://github.com/lcp/edk2-platforms/tree/fix- > > > > minnowboard-bds-v2 > > > > > > > > v2: > > > > * Add the missing MSG_URI_DP to > > BootOptionPriority() > > > > * Update the descriptioins of 2nd and 4th > patches > > > > * Add the 5th and 6th patches > > > > > > > > Cc: Zailiang Sun <zailiang....@intel.com> > > > > Cc: Yi Qian <yi.q...@intel.com> > > > > Cc: Michael D Kinney <michael.d.kin...@intel.com> > > > > > > > > Gary Lin (6): > > > > Vlv2TbltDevicePkg: Adjust the device priority > > > > Vlv2TbltDevicePkg: Add the missing > > BootManagerMenuApp > > > > Vlv2TbltDevicePkg: Only sort boot options when > > necessary > > > > Vlv2TbltDevicePkg: Clean up the unused > variables > > and function > > > > Vlv2TbltDevicePkg: Add the missing SMBIOS bits > > > > Vlv2TbltDevicePkg: Convert the device GUIDs of > > capsules to > > > > lowercase > > > > > > > > > > > > > > > Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/Genera > > > > teCapsule/GenCapsuleAll.py | 24 +++--- > > > > > > > > > > > Platform/Intel/Vlv2TbltDevicePkg/Library/DxePlatformBoo > > > > tManagerLib/BdsPlatform.c | 9 +- > > > > > > > > > > > Platform/Intel/Vlv2TbltDevicePkg/Library/DxePlatformBoo > > > > tManagerLib/PlatformBootOption.c | 86 ++++++----- > -- > > ---- > > > > --- > > > > Platform/Intel/Vlv2TbltDevicePkg/PlatformPkg.fdf > > > > | 3 +- > > > > > > Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc > > > > | 1 + > > > > > > Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > > > > | 1 + > > > > > > > > > > > Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/DataHubR > > > > ecords.h | 5 +- > > > > > > > > > > > Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscBios > > > > VendorData.c | 5 +- > > > > 8 files changed, 54 insertions(+), 80 > deletions(-) > > > > > > > > -- > > > > 2.22.0 > > > > > > > > > > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#45290): https://edk2.groups.io/g/devel/message/45290 Mute This Topic: https://groups.io/mt/32651914/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
