On Fri, Aug 09, 2019 at 02:54:31PM +0200, Laszlo Ersek wrote: > On 08/09/19 03:37, Feng, Bob C wrote: > > Thanks for your response. > > > > I'm going to push this patch set late today, if there is no more comments. > > Sorry, I have to disagree about that. There is a NACK standing from Leif > -- he will have to rescind that NACK explicitly, for you to push the series. > > Leif: can you please confirm, in light of the new information [*] if you > are OK with this v8 patchset being merged? > > [*] The new information is that "--hash" breaks "pick-up" after Ctrl-C, > independently of the present patchset. So, it's not a regression from > the new work, and if "--hash" is removed from the command line, the > "pick-up" is successful both with and without these patches.
Ah, it was not clear to me that the bug was reproducible with --hash without this set. (I read it as the bug was only reproducible with this set if using --hash, which is not the same thing.) In that case, I rescind my NACK. Thank you for the clarification, Laszlo. I would say this makes a fix for the --hash issue a hard requirement for the stable tag. Best Regards, Leif -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#45272): https://edk2.groups.io/g/devel/message/45272 Mute This Topic: https://groups.io/mt/32779325/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
