Reviewed-by: Jaben Carsey <jaben.car...@intel.com> Thanks -Jaben
> -----Original Message----- > From: Gao, Zhichao > Sent: Thursday, August 08, 2019 1:59 AM > To: devel@edk2.groups.io; Zhang, Shenglei <shenglei.zh...@intel.com> > Cc: Carsey, Jaben <jaben.car...@intel.com>; Ni, Ray <ray...@intel.com> > Subject: RE: [edk2-devel] [PATCH 2/3] > ShellPkg/UefiShellAcpiViewCommandLib: Add missing header files in INF > > Reviewed-by: Zhichao Gao <zhichao....@intel.com> > > Thanks, > Zhichao > > > -----Original Message----- > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > > Zhang, Shenglei > > Sent: Thursday, August 8, 2019 2:25 PM > > To: devel@edk2.groups.io > > Cc: Carsey, Jaben <jaben.car...@intel.com>; Ni, Ray <ray...@intel.com>; > > Gao, Zhichao <zhichao....@intel.com> > > Subject: [edk2-devel] [PATCH 2/3] > ShellPkg/UefiShellAcpiViewCommandLib: > > Add missing header files in INF > > > > MadtParser.h and PpttParser.h are actually used but missing INF file, which > > will generate warning message when building this package. > > > > Cc: Jaben Carsey <jaben.car...@intel.com> > > Cc: Ray Ni <ray...@intel.com> > > Cc: Zhichao Gao <zhichao....@intel.com> > > Signed-off-by: Shenglei Zhang <shenglei.zh...@intel.com> > > --- > > .../UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.inf | 2 > ++ > > 1 file changed, 2 insertions(+) > > > > diff --git > > > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewComm > > andLib.inf > > > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewComm > > andLib.inf > > index e06e2082a197..1e2fa52b00a3 100644 > > --- > > > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewComm > > andLib.inf > > +++ > > > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewComm > > +++ andLib.inf > > @@ -43,6 +43,8 @@ [Sources.common] > > Parsers/Srat/SratParser.c > > Parsers/Ssdt/SsdtParser.c > > Parsers/Xsdt/XsdtParser.c > > + Parsers/Madt/MadtParser.h > > + Parsers/Pptt/PpttParser.h > > > > [Packages] > > MdePkg/MdePkg.dec > > -- > > 2.18.0.windows.1 > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#45197): https://edk2.groups.io/g/devel/message/45197 Mute This Topic: https://groups.io/mt/32796056/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-