On 08/05/19 08:19, Wu, Hao A wrote: >> -----Original Message----- >> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >> Eric Jin >> Sent: Wednesday, July 31, 2019 10:59 PM >> To: devel@edk2.groups.io >> Subject: [edk2-devel] [PATCH 0/3] Enhance ESRT to support multiple >> controllers >> >> Multiple Controllers Support solution >> >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1525 >> >> The patch set is to makes enhancement to the ESRT when multiple >> same controllers exist in one system. >> >> Eric Jin (3): >> MdeModulePkg/EsrtFmpDxe: Merge multiple FMP into ESRT >> MdeModulePkg/EsrtFmpDxe: Correct LastAttemptVersion algorithm in ESRT >> MdeModulePkg/EsrtFmpDxe: Detect duplicate GUID/HardwareInstance > > > Hello Eric, > > After looking into the series, I found that patches 2/3 & 3/3 are actually > addressing issues introduced by the 1/3 patch. It looks to me that these > 3 patches should be squashed into 1 commit, since they all focus on adding > a feature for ESRT to support multiple controllers. > > However, originally, the 3 separate commits come from the edk2-staging > repository, so I am not very sure what approach should be adopted when > merging them back to the edk2 repo master branch. > > (Includes the stewards here for suggestions.) > > My personal preference is to merge them together as one patch.
Sorry about the late response. I certainly agree that a single patch series should avoid introducing a bug or esp. regression, just for another patch in the same series to fix it up. In that case, both halves indeed belong to a single patch. However, speaking generally (not knowing any specifics here), that doesn't mean that everything should be squashed into a single patch. The series (speaking generally) should still have a fine-grained structure; each patch should do as little, and as well isolated, as reasonably possible. Thanks Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#45002): https://edk2.groups.io/g/devel/message/45002 Mute This Topic: https://groups.io/mt/32667728/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
