Eric, My understanding to your patch is you want to avoid printing from AP because some platforms may choose wrong DebugLib instance for the CpuFeaturePei/Dxe driver, which leads to system hang. To make the platform happy and while the value of printing the debug message is less, the solution in your patch is to suppress the debug message unless a minor code change is made to turn on the debugging.
Given that there are many comments/suggestions on how to implement a MP safe debugging infra, I don't think implementing such a MP safe debugging infra can be quickly done. How about directly remove the debug message instead of disabling in your V2 patch? The goal of MP safe debugging infra is to provide a mechanism to print debug message in MP environment that doesn't depend on platform DSC library instance mapping. Can you please submit a BZ to capture that and also remember to attach the URL to this mail thread in BZ? We could use future TianoCore Design Meeting to discuss about this. Thanks, Ray > -----Original Message----- > From: Dong, Eric > Sent: Wednesday, July 31, 2019 3:35 PM > To: devel@edk2.groups.io > Cc: Ni, Ray <ray...@intel.com>; Laszlo Ersek <ler...@redhat.com> > Subject: [Patch 0/2] UefiCpuPkg: Default avoid print. > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1984 > > Current debug message brings much restriction for the platform which use > this driver. > > For PEI and DXE phase, platform mush link base DebugLib (without using any > pei/dxe services, even for its dependent libraries). > > This patch default disable this debug message, only open it when need to > debug the related code. > > Signed-off-by: Eric Dong <eric.d...@intel.com> > Cc: Ray Ni <ray...@intel.com> > Cc: Laszlo Ersek <ler...@redhat.com> > > Eric Dong (2): > UefiCpuPkg/RegisterCpuFeaturesLib: Default avoid print. > UefiCpuPkg/PiSmmCpuDxeSmm: Default avoid print. > > .../Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c | 4 +++- > UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c | 4 +++- > 2 files changed, 6 insertions(+), 2 deletions(-) > > -- > 2.21.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#44742): https://edk2.groups.io/g/devel/message/44742 Mute This Topic: https://groups.io/mt/32664465/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
