>>> ...would it be worth having a return value here and Print()ing a >>> message visible regardless of build profile if this function fails? >> >> Yes, I think that would be very sensible, but it would also be inconsistent >> with the rest of the code: all of the other device-tree-modifying functions >> in FdtDxe.c are declared as VOID and use only DEBUG to report errors. >> >> Changing this pattern throughout FdtDxe.c should, I think, be a completely >> separate patch. Would it be possible to merge the current patch, and I can >> then follow up with a second patch to improve the error visibility in >> non-debug builds? > > Yeah, that works for me.
As promised, here is the subsequent patch to improve error visibility throughout FdtDxe. Michael Brown (1): Platform/RPi3: Report device tree modification errors using Print() .../RaspberryPi/RPi3/Drivers/FdtDxe/FdtDxe.c | 102 ++++++++++++------ 1 file changed, 70 insertions(+), 32 deletions(-) -- 2.21.0 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#44370): https://edk2.groups.io/g/devel/message/44370 Mute This Topic: https://groups.io/mt/32596680/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
