Patch looks fine for me. Reviewed-by: Bob Feng <bob.c.f...@intel.com>
-----Original Message----- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Leif Lindholm Sent: Friday, July 19, 2019 5:00 PM To: Laszlo Ersek <ler...@redhat.com> Cc: edk2-devel-groups-io <devel@edk2.groups.io>; Andrew Fish <af...@apple.com>; Kinney, Michael D <michael.d.kin...@intel.com>; Philippe Mathieu-Daude <phi...@redhat.com>; Feng, Bob C <bob.c.f...@intel.com>; Gao, Liming <liming....@intel.com>; Wu, Hao A <hao.a...@intel.com>; Stefan Berger <stef...@linux.ibm.com> Subject: Re: [edk2-devel] [PATCH 0/3] add GetMaintainer.py helper script (and Maintainers.txt format change) On Thu, Jul 18, 2019 at 11:17:30PM +0200, Laszlo Ersek wrote: > On 07/18/19 18:27, Leif Lindholm wrote: > > Laszlo, Hao - I have prepared a set for pushing as below. > > > > (Reviewed-by: Leif Lindholm <leif.lindh...@linaro.org> for all of > > your > > patches.) > > *But*, I need a review from Bob and/or Liming before I push the final one: > > "BaseTools: add GetMaintainer.py script" - > > https://edk2.groups.io/g/devel/message/43666 > > > > I have verified reviews/acks by all affected reviewers, except for > > Stefan Berger for Ovmf TCG/TPM2. > > Stefan's R-b has arrived as well: > > http://mid.mail-archive.com/7201b3fb-d84b-30e0-61c8-bf9bb9defa7a@linux > .ibm.com > > So, I agree, those four patches regarding OvmfPkg reviewership are now > fully approved. > > Please pick up Phil's feedback as well. > > > While I would prefer to have that too, this is a file format shift - > > not a change in responsibility areas. > > Laszlo, do you agree? > > If so, I can push 1-7/8 as is. > > See above -- then I'm OK. 1-7/8 pushed as: 3dafa0382286..296c908c6968 Will push the GetMaintainer.py script once approved by BaseTools maintainers. Thanks! / Leif > Thank you! > Laszlo > > > > > / > > Leif > > > > Hao A Wu (1): > > Maintainers.txt: Fine-grained review ownership for MdeModulePkg > > > > Laszlo Ersek (4): > > Maintainers.txt: split out section "ArmVirtPkg: modules used on Xen" > > Maintainers.txt: split out section "OvmfPkg: Xen-related modules" > > Maintainers.txt: split out section "OvmfPkg: TCG- and TPM2-related > > modules" > > Maintainers.txt: split out section "OvmfPkg: CSM modules" > > > > Leif Lindholm (3): > > Maintainers.txt: update for filesystem area descriptions > > Maintainers.txt: add wildcard path association for Arm/AArch64 > > BaseTools: add GetMaintainer.py script > > > > > > On Fri, 12 Jul 2019 at 18:01, Leif Lindholm > > <leif.lindh...@linaro.org> > > wrote: > > > >> Changes are available directly from: > >> > >> https://git.linaro.org/people/leif.lindholm/edk2.git/log/?h=upstrea > >> ming/git-maintainer-v1 > >> > >> This series adds new tags to the Maintainers.txt format, making it > >> possible to describe which filesystem paths are looked after by > >> which people, and hence automating the extraction of a list over > >> who should be cc:d on a patch submission. > >> > >> Remaining shorcomings in v1: > >> - Will still be misparsing OvmfPkg and MdeModulePkg due to non-tag lines > >> interspersed with the tag lines. These lines will be removed as areas of > >> responsibility is formally rewritten as tags. > >> - * Wildcard support is not fully filesystem compliant except in first or > >> last position in the file pattern (it translates as regex .* elsewhere). > >> However, actual cases of mismatch are expected to be unlikely, and they > >> will be false positives rather than false negatives - so I think this is > >> good enough at least for a start. > >> - Provides no information of why certain people or meiling lists were > >> picked - it just bundles all recipients up, deduplicates them, and > >> prints them out. > >> > >> Using the script requires the gitpython module to be installed. > >> > >> Worthwhile mentioning outside the ChangeLog is the added -l flag, > >> which lets you look up what a given path would return in the way of > >> matches. > >> E.g. "python BaseTools/Scripts/GetMaintainer.py -l Non/Existing/Path" > >> would return: > >> --- > >> Non/Existing/Path > >> "Non/Existing/Path": no maintainers found, looking for default > >> Andrew Fish <af...@apple.com> > >> Laszlo Ersek <ler...@redhat.com> > >> Leif Lindholm <leif.lindh...@linaro.org> > >> Michael D Kinney <michael.d.kin...@intel.com> > >> devel@edk2.groups.io > >> --- > >> > >> This series would still result in GetMaintainers.py missing some > >> maintainers/reviewers due to descriptions in prose rather than > >> filename patterns. My preferred way of handling this would be to > >> merge 1-2/3 as soon as found acceptable, following up and merging > >> patches to update ArmVirtPkg, MdeModulePkg, and OvmfPkg, and > >> finally once the file is consistent, proceed to merge 3/3. > >> > >> Changelog: > >> v1: > >> - Rebase to current Maintainers.txt. > >> - Fix typos and missed bits in Maintainers.txt. > >> - Get rid of the magic '<default>' filename, let the single-char '*' > >> wildcard resolve this (_using_ the magic '<default>' filename in the > >> script, but treating it as if it was a file in the top-level directory). > >> - Add -l flag to script to look up which maintainers would be returned for > >> a given path (which need not exist). > >> rfc: > >> - Split patches up > >> - one for new Maintainers.txt format (documentation and F: tags). > >> - one for adding a new wilcards responsibility area for */Arm, */AArch64 > >> - one for the GetMaintainer.py script > >> - Reworked wildcard handling based on Laszlo's explanation > >> - Trailing / covers everything under that directory > >> - Trailing * does not cover subdirectories > >> - Added support for X: tag > >> - Added support for magic '<default>' pathname > >> - Also prints mailing list addresses for matching L: tags > >> > >> Cc: Andrew Fish <af...@apple.com> > >> Cc: Laszlo Ersek <ler...@redhat.com> > >> Cc: Michael D Kinney <michael.d.kin...@intel.com> > >> Cc: Bob Feng <bob.c.f...@intel.com> > >> Cc: Liming Gao <liming....@intel.com> > >> Cc: Philippe Mathieu-Daude <phi...@redhat.com> > >> Cc: "Wu, Hao A" <hao.a...@intel.com> > >> > >> Leif Lindholm (3): > >> Maintainers.txt: update for filesystem area descriptions > >> Maintainers.txt: add wildcard path association for Arm/AArch64 > >> BaseTools: add GetMaintainer.py script > >> > >> BaseTools/Scripts/GetMaintainer.py | 190 +++++++++++++++++++++++++++++ > >> Maintainers.txt | 54 ++++++++ > >> 2 files changed, 244 insertions(+) create mode 100644 > >> BaseTools/Scripts/GetMaintainer.py > >> > >> -- > >> 2.20.1 > >> > >> > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#44280): https://edk2.groups.io/g/devel/message/44280 Mute This Topic: https://groups.io/mt/32524902/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
