On 07/19/19 18:43, Laszlo Ersek wrote: > Repo: https://github.com/lersek/edk2.git > Branch: internal_hdrs > > The BaseTools build feature introduced for TianoCore#1804 / in commit > 1fa6699e6cd4 ("BaseTools: Add a checking for Sources section in INF > file", 2019-06-10) logs some (non-fatal) warnings about unlisted > internal header files. List those files explicitly. > > Note: header files are added in lexicographical order only if the > underlying INF file already keeps the [Sources] and [LibraryClasses] > sections in lexicographical order. Otherwise, header files are added in > rough "logical" order. > > The set of INF files to update was determined as follows: > > - build the OVMF and ArmVirt platforms > > - collect all the warnings > > - exclude all warnings that refer to "CryptoPkg/Library/OpensslLib" > (parts of those INF files are generated, so it's likely that the > generator should be updated -- but that's for someone else) > > - for each remaining INF file, check if there are *other* INF files in > the same directory (possibly unused by OVMF and ArmVirt platforms) > > - fix up each collected INF file as needed (check if at least one C file > listed in [Sources] actually includes the reported header) > > The series was validated as follows: > > - build the OVMF and ArmVirt platforms > > - rebuild each modified INF with the "-m" switch, via its own package > platform DSC (not via OVMF / ArmVirt) > > - wherever [Sources] is split between arches, rebuild the INF for all > relevant arches > > - ascertain the warnings are gone > > Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> > Cc: Jian Wang <jian.j.w...@intel.com> > Cc: Leif Lindholm <leif.lindh...@linaro.org> > Cc: Ting Ye <ting...@intel.com> > > Thanks > Laszlo > > Laszlo Ersek (4): > ArmPkg: list module-internal header files in INF [Sources] > ArmPlatformPkg: list module-internal header files in INF [Sources] > CryptoPkg/BaseCryptLib: list module-internal header files in INF > [Sources] > EmbeddedPkg: list module-internal header files in INF [Sources] > > ArmPkg/Drivers/ArmGic/ArmGicDxe.inf | 1 + > ArmPkg/Library/ArmLib/ArmBaseLib.inf | 3 > +++ > ArmPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf | 1 + > ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.inf | 1 + > ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockLib.inf | 1 + > ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf | 1 + > ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf | 1 + > CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf | 1 + > CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf | 1 + > CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf | 1 + > EmbeddedPkg/Library/FdtLib/FdtLib.inf | 1 + > EmbeddedPkg/Library/PrePiLib/PrePiLib.inf | 1 + > 12 files changed, 14 insertions(+) >
Pushed: bb824f685d76..f6f1e0b7c292. Thanks! Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#44161): https://edk2.groups.io/g/devel/message/44161 Mute This Topic: https://groups.io/mt/32529014/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
