We could consider checking for these type of issues in the ECC tool instead of build and make it an error from ECC instead of a warning.
Mike > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] > On Behalf Of Laszlo Ersek > Sent: Monday, July 22, 2019 10:33 AM > To: Leif Lindholm <leif.lindh...@linaro.org> > Cc: edk2-devel-groups-io <devel@edk2.groups.io>; Ard > Biesheuvel <ard.biesheu...@linaro.org>; Wang, Jian J > <jian.j.w...@intel.com>; Ye, Ting <ting...@intel.com> > Subject: Re: [edk2-devel] [PATCH 0/4] Arm, ArmPlatform, > Crypto, Embedded: list internal headers in [Sources] > > On 07/22/19 12:37, Leif Lindholm wrote: > > On Fri, Jul 19, 2019 at 06:43:15PM +0200, Laszlo Ersek > wrote: > >> Repo: https://github.com/lersek/edk2.git > >> Branch: internal_hdrs > >> > >> The BaseTools build feature introduced for > TianoCore#1804 / in commit > >> 1fa6699e6cd4 ("BaseTools: Add a checking for Sources > section in INF > >> file", 2019-06-10) logs some (non-fatal) warnings > about unlisted > >> internal header files. List those files explicitly. > > > > Urgh. > > Yeah. I'm still not super comfortable with this > duplication of > > dependency scanning (as discussed in > > https://edk2.groups.io/g/devel/topic/31866190), but I > have to confess > > I also don't really care enough to do anything about > it. > > > > So, while I'm tempted to keep the warnings around as a > reminder, if > > you prefer to get rid of them - for the pat of the > series I was cc:d on: > > Reviewed-by: Leif Lindholm <leif.lindh...@linaro.org> > > Thanks! > > Yes, the warnings are an annoyance, and they are valid > too. How the INF files are caught / reported is a > separate question IMO. > > Thanks! > Laszlo > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#44146): https://edk2.groups.io/g/devel/message/44146 Mute This Topic: https://groups.io/mt/32529014/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
