On Fri, Jul 05, 2019 at 02:21:13PM +0200, Laszlo Ersek wrote: > The patches on the list are malformed. They have > > Content-Transfer-Encoding: quoted-printable > > which is fine, in itself; however, they have CR-CR-LF line terminators. > > For example, from the first patch: > > diff --git a/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.inf b/OvmfPkg/L= > ibrary/ResetSystemLib/ResetSystemLib.inf > index 7c44f99a5c..2f24dac87f 100644 > --- a/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.inf > +++ b/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.inf > @@ -30,4 +30,5 @@ [Packages] > [LibraryClasses]=0D=0D > DebugLib=0D=0D > IoLib=0D=0D > + PciLib=0D=0D > TimerLib=0D=0D > > Note "=0D=0D". > > Now, if I try to apply this full set with git-am like that, the first > patch in the series applies, but the second still fails: > > > error: corrupt patch at line 23 > > Patch failed at 0002 OvmfPkg: Create platform OvmfXen > > Based on the email headers, the "iphmx.com" references suggest (via a > google search) "Cisco's Ironport Cloud email service". > > I think that email service (MTA) is broken. > > If you could use a different MTA (or get the current one fixed), that > would be helpful. (Yes, yes: if the edk2 project didn't use CRLF line > terminators, that would be *even more* helpful.)
I'm not sure that using a different MTA is going to help. I don't think I can find a patch on the list that I can apply (without using unix2dos). I did send a patch to my gmail address, and it looks fine (=0D in the expected places and nowhere else). So maybe when a patch is sent through a mailing list, some more formating is done? Anyway, can I try sending patch encoded in base64 instead of quoted-printable? That would probably work better. I found <20190704040731.5303-1-g...@suse.com> on the list that is base64 encoded, that I can easily apply and patchew too. -- Anthony PERARD -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#44055): https://edk2.groups.io/g/devel/message/44055 Mute This Topic: https://groups.io/mt/32308564/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
