On 07/16/19 11:41, Philippe Mathieu-Daudé wrote: > Hi Laszlo, > > On 7/16/19 10:38 AM, Philippe Mathieu-Daudé wrote: >> On 7/2/19 12:28 PM, Laszlo Ersek wrote: >>> Rewrite Base64Decode() from scratch, due to reasons listed in the second >>> reference below. >>> >>> As first step, redo the interface contract, and replace the current >>> implementation with a stub that asserts FALSE, then fails. >>> >>> Cc: Liming Gao <liming....@intel.com> >>> Cc: Marvin Häuser <mhaeu...@outlook.de> >>> Cc: Michael D Kinney <michael.d.kin...@intel.com> >>> Cc: Philippe Mathieu-Daudé <phi...@redhat.com> >>> Cc: Zhichao Gao <zhichao....@intel.com> >>> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1891 >>> Ref: >>> c495bd0b-ea4d-7206-8a4f-a7149760d19a@redhat.com">http://mid.mail-archive.com/c495bd0b-ea4d-7206-8a4f-a7149760d19a@redhat.com >>> Signed-off-by: Laszlo Ersek <ler...@redhat.com> >>> --- >>> MdePkg/Include/Library/BaseLib.h | 99 +++++-- >>> MdePkg/Library/BaseLib/String.c | 285 ++++++-------------- >>> 2 files changed, 168 insertions(+), 216 deletions(-) > > You forgot to update the copyright in both files.
I didn't: I never intended to. Updating or extending *existing* copyright notices is not a general edk2 requirement. Some companies insist that their associates do that, when they contribute patches. Red Hat doesn't (we don't extend copyright notices like that in QEMU either). Thanks, Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43789): https://edk2.groups.io/g/devel/message/43789 Mute This Topic: https://groups.io/mt/32284615/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
