On 07/15/19 16:40, Rebecca Cran wrote: > On 2019-07-12 16:21, Laszlo Ersek wrote: >> >> As long as my opinion counts... (and I totally don't insist that it do): >> the above task list will make for a nice 6-part patch series. :) >> >> (When someone is tempted to capture a *list* of changes in a single >> commit message, that frequently indicates that the patch should be split >> up, so that each change get its own dedicated patch.) > > > While I can see your point, in this case I think splitting the patch up > into 6 parts would be excessive. All the changes are to a single file, > and a couple of the changes in the list are to single lines.
Fair enough, as long as you don't insist on my Reviewed-by in particular. :) I won't block the patch just because of this, but I also won't try to decipher changes made for six different goals from each other. Thanks, Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43736): https://edk2.groups.io/g/devel/message/43736 Mute This Topic: https://groups.io/mt/32421563/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
