Hi Antoine, Patch looks fine. Would you attach the patch file again? I can't extract the patch file from the mail.
Pccts is the predecessor of ANTLR. It's dead. Thanks, Bob -----Original Message----- From: Leif Lindholm [mailto:leif.lindh...@linaro.org] Sent: Thursday, July 4, 2019 9:07 PM To: devel@edk2.groups.io; co...@gmx.fr Cc: Feng, Bob C <bob.c.f...@intel.com>; Gao, Liming <liming....@intel.com> Subject: Re: [edk2-devel] [PATCH] BaseTools: Fix encoding typos +Bob, Liming Personally, I'm not sure what should be done here. Normally for an imported piece of code, I would say "fix this upstream", but Pccts is as far as I can tell _long_ dead. On Sat, Jun 29, 2019 at 05:02:03AM -0700, Cœur wrote: > Fix encoding typos in BaseTools by using UTF-8. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Coeur <co...@gmx.fr> > --- > BaseTools/Source/C/VfrCompile/Pccts/CHANGES_FROM_133.txt | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/BaseTools/Source/C/VfrCompile/Pccts/CHANGES_FROM_133.txt > b/BaseTools/Source/C/VfrCompile/Pccts/CHANGES_FROM_133.txt > index 4d84d1c19c..c3fcadfd59 100644 > --- a/BaseTools/Source/C/VfrCompile/Pccts/CHANGES_FROM_133.txt > +++ b/BaseTools/Source/C/VfrCompile/Pccts/CHANGES_FROM_133.txt > @@ -40,7 +40,7 @@ List of Implemented Fixes and Changes for > Maintenance Releases of PCCTS #309. (Changed in MR32) Renamed baseName > because of VMS name conflict > > Renamed baseName to pcctsBaseName to avoid library name conflict with > - VMS library routine. Reported by Jean-FranÁois PI…RONNE. > + VMS library routine. Reported by Jean-Fran√ßois PI√âRONNE. > > #308. (Changed in MR32) Used "template" as name of formal in C routine > > @@ -975,7 +975,7 @@ List of Implemented Fixes and Changes for > Maintenance Releases of PCCTS > > #249. (MR21) Changes for DEC/VMS systems > > - Jean-FranÁois PiÈronne (jfp altavista.net) has updated some > + Jean-Fran√ßois Pi√©ronne (jfp altavista.net) has updated some > VMS related command files and fixed some minor problems related to > building pccts under the DEC/VMS operating system. For DEC/VMS users > the most important differences are: > @@ -1750,7 +1750,7 @@ List of Implemented Fixes and Changes for > Maintenance Releases of PCCTS Under certain circumstances a predicate > test could generate a #line directive which was not at column 1. > > - Reported with fix by David KÂgedal (davidk lysator.liu.se) > + Reported with fix by David K√•gedal (davidk lysator.liu.se) > (http://www.lysator.liu.se/~davidk/). > > #194. (Changed in MR14) (C Mode only) Demand lookahead with #tokclass > -- > 2.20.1 (Apple Git-117) > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43321): https://edk2.groups.io/g/devel/message/43321 Mute This Topic: https://groups.io/mt/32250884/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
