On Thu, Jul 04, 2019 at 06:14:04AM +0000, Wu, Hao A wrote: > I do met a little problem that for a patch that touches multiple features, > the contacts order in the output is not ideally perfect: > > Content in Maintainers.txt: > ''' > MdeModulePkg > F: MdeModulePkg/ > W: https://github.com/tianocore/tianocore.github.io/wiki/MdeModulePkg > M: Jian J Wang <jian.j.w...@intel.com> > M: Hao A Wu <hao.a...@intel.com> > > F: MdeModulePkg/*Ufs*/ > R: Ufs Guy <u...@test.com> > > F: MdeModulePkg/Include/*Hii*.h > F: MdeModulePkg/*Hii*/ > R: Hii Guy <h...@test.com> > ''' > > Script output: > ''' > $ py BaseTools/Scripts/GetMaintainer.py HEAD > MdeModulePkg/Bus/Pci/UfsPciHcDxe/UfsPciHcDxe.inf > MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabase.uni > Jian J Wang <jian.j.w...@intel.com> > Hao A Wu <hao.a...@intel.com> > Ufs Guy <u...@test.com> > devel@edk2.groups.io > Hii Guy <h...@test.com> > ''' > > The 'Hii Guy' is at the end of the list.
Totally agree. The idea was to keep the first revision simple. Another thing missing (that I would argue is even more important than listed order), is an indication of *why* said person is listed. > But this is a rather minor problem and does not impact the use at all. Good. I will respin the set based on Laszlo's feedback on previous version and resubmit. Best Regards, Leif -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43277): https://edk2.groups.io/g/devel/message/43277 Mute This Topic: https://groups.io/mt/32067941/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
