On 07/01/19 13:14, Anthony PERARD wrote:
> Calling DisconnectController() on children isn't part of the job of
> EFI_DRIVER_BINDING_PROTOCOL.Stop() as it only needs to deallocate
> resources allocated in Start(). The disconnection will happen when
> both DevicePath and XenBus protocols gets uninstalled.
>
> Reported-by: Laszlo Ersek <ler...@redhat.com>
> Signed-off-by: Anthony PERARD <anthony.per...@citrix.com>
> ---
>
> Notes:
> Please apply this patch after:
> "OvmfPkg/XenBusDxe: Close XenIoProtocol openned by children"
>
> OvmfPkg/XenBusDxe/XenBusDxe.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/OvmfPkg/XenBusDxe/XenBusDxe.c b/OvmfPkg/XenBusDxe/XenBusDxe.c
> index 7c07a96650..634c7b71eb 100644
> --- a/OvmfPkg/XenBusDxe/XenBusDxe.c
> +++ b/OvmfPkg/XenBusDxe/XenBusDxe.c
> @@ -446,12 +446,6 @@ XenBusDxeDriverBindingStop (
> continue;
> }
> ChildData = XENBUS_PRIVATE_DATA_FROM_THIS (XenBusIo);
> - Status = gBS->DisconnectController (ChildData->Handle, NULL, NULL);
> - if (EFI_ERROR (Status)) {
> - DEBUG ((EFI_D_ERROR, "XenBusDxe: error disconnecting child: %r\n",
> - Status));
> - continue;
> - }
>
> Status = gBS->CloseProtocol (Dev->ControllerHandle, &gXenIoProtocolGuid,
> Dev->This->DriverBindingHandle, ChildData->Handle);
>
Commit 6a1f06fadb26.
Thanks
Laszlo
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#43128): https://edk2.groups.io/g/devel/message/43128
Mute This Topic: https://groups.io/mt/32270256/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
