Reviewed-by: Jian J Wang <jian.j.w...@intel.com> > -----Original Message----- > From: Gao, Zhichao > Sent: Monday, June 17, 2019 3:54 PM > To: Ni, Ray <ray...@intel.com>; devel@edk2.groups.io; Yao, Jiewen > <jiewen....@intel.com>; Zhang, Shenglei <shenglei.zh...@intel.com> > Cc: Bret Barkelew <bret.barke...@microsoft.com>; Zhang, Chao B > <chao.b.zh...@intel.com>; Wang, Jian J <jian.j.w...@intel.com>; Gao, Liming > <liming....@intel.com>; Sean Brogan <sean.bro...@microsoft.com>; Michael > Turner <michael.tur...@microsoft.com>; Leif Lindholm > <leif.lindh...@linaro.org> > Subject: RE: [edk2-devel] [PATCH v2] SecurityPkg: Add missing instances for > build > only > > Added: https://bugzilla.tianocore.org/show_bug.cgi?id=1919 > > Thanks, > Zhichao > > > -----Original Message----- > > From: Ni, Ray > > Sent: Friday, June 14, 2019 4:50 PM > > To: devel@edk2.groups.io; Yao, Jiewen <jiewen....@intel.com>; Gao, > > Zhichao <zhichao....@intel.com> > > Cc: Bret Barkelew <bret.barke...@microsoft.com>; Zhang, Chao B > > <chao.b.zh...@intel.com>; Wang, Jian J <jian.j.w...@intel.com>; Gao, > > Liming <liming....@intel.com>; Sean Brogan <sean.bro...@microsoft.com>; > > Michael Turner <michael.tur...@microsoft.com>; Leif Lindholm > > <leif.lindh...@linaro.org> > > Subject: RE: [edk2-devel] [PATCH v2] SecurityPkg: Add missing instances for > > build only > > > > Yes I agree. > > Since UID feature was completely dropped early this year, this is a missing > > library that should be removed together with UID. > > > > Zhichao, > > Can you help submit a BZ for this removal? > > I am ok with your current patch to include this library. This library can be > > removed by further patch that removes DxeDeferImageLoadLib. > > > > Thanks, > > Ray > > > > > -----Original Message----- > > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Yao, > > > Jiewen > > > Sent: Friday, June 14, 2019 4:48 PM > > > To: devel@edk2.groups.io; Gao, Zhichao <zhichao....@intel.com> > > > Cc: Bret Barkelew <bret.barke...@microsoft.com>; Zhang, Chao B > > > <chao.b.zh...@intel.com>; Wang, Jian J <jian.j.w...@intel.com>; Gao, > > > Liming <liming....@intel.com>; Sean Brogan > > > <sean.bro...@microsoft.com>; Michael Turner > > > <michael.tur...@microsoft.com>; Leif Lindholm > > > <leif.lindh...@linaro.org> > > > Subject: Re: [edk2-devel] [PATCH v2] SecurityPkg: Add missing > > > instances for build only > > > > > > Hi > > > It is good to add those to build. > > > > > > However, I think we should remove > > > SecurityPkg\Library\DxeDeferImageLoadLib from the code base. > > > > > > This lib supports old UID and may conflict with > > > MdeModulePkg\Universal\SecurityStubDxe\Defer3rdPartyImageLoad.c > > > > > > > > > Thank you > > > Yao Jiewen > > > > > > > -----Original Message----- > > > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf > > > > Of Gao, Zhichao > > > > Sent: Friday, June 14, 2019 4:35 PM > > > > To: devel@edk2.groups.io > > > > Cc: Bret Barkelew <bret.barke...@microsoft.com>; Zhang, Chao B > > > > <chao.b.zh...@intel.com>; Yao, Jiewen <jiewen....@intel.com>; Wang, > > > > Jian J <jian.j.w...@intel.com>; Gao, Liming <liming....@intel.com>; > > > > Sean Brogan <sean.bro...@microsoft.com>; Michael Turner > > > > <michael.tur...@microsoft.com>; Leif Lindholm > > > > <leif.lindh...@linaro.org>; Gao, Zhichao <zhichao....@intel.com> > > > > Subject: [edk2-devel] [PATCH v2] SecurityPkg: Add missing instances > > > > for build only > > > > > > > > From: Bret Barkelew <bret.barke...@microsoft.com> > > > > > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1902 > > > > > > > > Add the missing instances to the [Components] of dsc file for build > > > > only. > > > > > > > > Cc: Chao Zhang <chao.b.zh...@intel.com> > > > > Cc: Jiewen Yao <jiewen....@intel.com> > > > > Cc: Jian Wang <jian.j.w...@intel.com> > > > > Cc: Liming Gao <liming....@intel.com> > > > > Cc: Sean Brogan <sean.bro...@microsoft.com> > > > > Cc: Michael Turner <michael.tur...@microsoft.com> > > > > Cc: Bret Barkelew <bret.barke...@microsoft.com> > > > > Cc: Leif Lindholm <leif.lindh...@linaro.org> > > > > Signed-off-by: Zhichao gao <zhichao....@intel.com> > > > > --- > > > > V2: fix with Laszlo's comment: > > > > https://edk2.groups.io/g/devel/message/42273 > > > > > > > > SecurityPkg/SecurityPkg.dsc | 6 ++++++ > > > > 1 file changed, 6 insertions(+) > > > > > > > > diff --git a/SecurityPkg/SecurityPkg.dsc > > > > b/SecurityPkg/SecurityPkg.dsc index a2ee0528f0..ed0da7563d 100644 > > > > --- a/SecurityPkg/SecurityPkg.dsc > > > > +++ b/SecurityPkg/SecurityPkg.dsc > > > > @@ -199,6 +199,12 @@ > > > > > > > > > > > > > SecurityPkg/Library/FmpAuthenticationLibPkcs7/FmpAuthenticationLibPkcs > > > > 7 > > > > .inf > > > > > > > > > > > > > SecurityPkg/Library/FmpAuthenticationLibRsa2048Sha256/FmpAuthenticatio > > > > nLibRsa2048Sha256.inf > > > > > > > > + > > SecurityPkg/Library/DxeDeferImageLoadLib/DxeDeferImageLoadLib.inf > > > > + > > > > > > > > > SecurityPkg/Library/DxeTpmMeasurementLib/DxeTpmMeasurementLib.inf > > > > + > > > > + SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.in > > > > + f SecurityPkg/Library/Tcg2PpVendorLibNull/Tcg2PpVendorLibNull.inf > > > > + SecurityPkg/Library/TcgPpVendorLibNull/TcgPpVendorLibNull.inf > > > > + > > > > [Components.IA32, Components.X64, Components.ARM, > > > Components.AARCH64] > > > > SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf > > > > > > > > -- > > > > 2.21.0.windows.1 > > > > > > > > > > > > > > > > > > > > >
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#42787): https://edk2.groups.io/g/devel/message/42787 Mute This Topic: https://groups.io/mt/32061825/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
