Zhiju: The change is good. What test have you done? Thanks Liming > -----Original Message----- > From: Fan, ZhijuX > Sent: Friday, June 21, 2019 10:33 AM > To: devel@edk2.groups.io > Cc: Gao, Liming <liming....@intel.com>; Feng, Bob C <bob.c.f...@intel.com> > Subject: [PATCH] BaseTools:Linux changes the way the latest version is judged > > BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1929 > > Some Linux servers do not have BC installed,so errors occur. > So the judgment was changed to avoid this error. > > Cc: Bob Feng <bob.c.f...@intel.com> > Cc: Liming Gao <liming....@intel.com> > Signed-off-by: Zhiju.Fan <zhijux....@intel.com> > --- > edksetup.sh | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/edksetup.sh b/edksetup.sh > index c7b2e1e201..0723e7b85a 100755 > --- a/edksetup.sh > +++ b/edksetup.sh > @@ -122,8 +122,7 @@ function SetupPython3() > export PYTHON_COMMAND=$python > continue > fi > - ret=`echo "$origin_version < $python_version" |bc` > - if [ "$ret" -eq 1 ]; then > + if [ "$origin_version" \< "$python_version" ]; then > origin_version=$python_version > export PYTHON_COMMAND=$python > fi > @@ -165,8 +164,7 @@ function SetupPython() > export PYTHON_COMMAND=$python > continue > fi > - ret=`echo "$origin_version < $python_version" |bc` > - if [ "$ret" -eq 1 ]; then > + if [ "$origin_version" \< "$python_version" ]; then > origin_version=$python_version > export PYTHON_COMMAND=$python > fi > -- > 2.14.1.windows.1
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#42730): https://edk2.groups.io/g/devel/message/42730 Mute This Topic: https://groups.io/mt/32154778/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
