Sorry, I missed the first mail. I saw there is no V2 tag in this series, so I think it is the first mail. My apology.
I have no concern on FitGen - it is Intel only. You can check in at first. FMMT/FCE is common. I think BaseTools is more proper place. "It is not validated" - it seems a weird justification to me. Or does it mean, for any future feature Intel/ARM people contribute, we should treat Platform package as the first choice, just because the it is cross validated? May I understand more on the rule we have today on what goes to EDK2 repo and what goes to EDK2-PLATFORM repo? Thank you Yao Jiewen > -----Original Message----- > From: Gao, Liming > Sent: Friday, June 21, 2019 10:31 AM > To: Yao, Jiewen <jiewen....@intel.com>; devel@edk2.groups.io; Zhang, > Shenglei <shenglei.zh...@intel.com> > Cc: Feng, Bob C <bob.c.f...@intel.com> > Subject: RE: [edk2-devel] [edk2-platform patch 0/6] Add tools FMMT FCE > and FitGen > > Jiewen: > I give the comments > https://edk2.groups.io/g/devel/message/42545?p=,,,20,0,0,0::Created,,FM > MT,20,2,0,32013143 for the patch BaseTools/FCE: Add a tool FCE > > I give new proposal https://edk2.groups.io/g/devel/message/42546 for > those tools. > > Thanks > Liming > > -----Original Message----- > > From: Yao, Jiewen > > Sent: Friday, June 21, 2019 10:26 AM > > To: devel@edk2.groups.io; Zhang, Shenglei <shenglei.zh...@intel.com> > > Cc: Feng, Bob C <bob.c.f...@intel.com>; Gao, Liming > <liming....@intel.com>; Yao, Jiewen <jiewen....@intel.com> > > Subject: RE: [edk2-devel] [edk2-platform patch 0/6] Add tools FMMT FCE > and FitGen > > > > HI > > I saw some conflict: > > ========= > > BaseTools/FCE: Add a tool FCE > > Add FMMT and FCE into Platform/Intel/Tools. > > ========= > > > > I agree that FitGet goes to Intel silicon. > > > > Should we put both FCE/FMMT to BaseTools? > > > > Thank you > > Yao Jiewen > > > > > > > -----Original Message----- > > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf > Of > > > Zhang, Shenglei > > > Sent: Friday, June 21, 2019 9:27 AM > > > To: devel@edk2.groups.io > > > Cc: Feng, Bob C <bob.c.f...@intel.com>; Gao, Liming > > > <liming....@intel.com> > > > Subject: [edk2-devel] [edk2-platform patch 0/6] Add tools FMMT FCE and > > > FitGen > > > > > > Add FMMT and FCE into Platform/Intel/Tools. > > > Add FitGen into Silicon/Intel/Tools. > > > https://bugzilla.tianocore.org/show_bug.cgi?id=1847 > > > https://bugzilla.tianocore.org/show_bug.cgi?id=1848 > > > https://bugzilla.tianocore.org/show_bug.cgi?id=1849 > > > > > > Cc: Bob Feng <bob.c.f...@intel.com> > > > Cc: Liming Gao <liming....@intel.com> > > > Shenglei Zhang (6): > > > Platform/Tools: Add a tool FMMT > > > Platform/Tools: Add a tool BfmLib > > > BaseTools/FCE: Add a tool FCE > > > Platform/Tools: Add top level Makefile and GNUMakefile > > > Silicon/Tools: Add a tool FitGen > > > Silicon/Tools: Add top level Makefile and GNUMakefile > > > > > > Platform/Intel/Tools/BfmLib/BfmLib.c | 4355 +++++++++++ > > > Platform/Intel/Tools/BfmLib/BinFileManager.c | 1024 +++ > > > Platform/Intel/Tools/BfmLib/BinFileManager.h | 439 ++ > > > Platform/Intel/Tools/BfmLib/GNUmakefile | 15 + > > > Platform/Intel/Tools/BfmLib/Makefile | 17 + > > > Platform/Intel/Tools/FCE/BinaryCreate.c | 216 + > > > Platform/Intel/Tools/FCE/BinaryCreate.h | 157 + > > > Platform/Intel/Tools/FCE/BinaryParse.c | 1326 ++++ > > > Platform/Intel/Tools/FCE/BinaryParse.h | 187 + > > > Platform/Intel/Tools/FCE/Common.c | 2183 ++++++ > > > Platform/Intel/Tools/FCE/Common.h | 999 +++ > > > Platform/Intel/Tools/FCE/Expression.c | 2367 ++++++ > > > Platform/Intel/Tools/FCE/Fce.c | 6449 > > > +++++++++++++++++ > > > Platform/Intel/Tools/FCE/Fce.h | 447 ++ > > > Platform/Intel/Tools/FCE/GNUmakefile | 22 + > > > Platform/Intel/Tools/FCE/IfrParse.c | 4836 ++++++++++++ > > > Platform/Intel/Tools/FCE/IfrParse.h | 789 ++ > > > Platform/Intel/Tools/FCE/Makefile | 19 + > > > .../Intel/Tools/FCE/MonotonicBasedVariable.c | 874 +++ > > > .../Intel/Tools/FCE/MonotonicBasedVariable.h | 162 + > > > Platform/Intel/Tools/FCE/TimeBasedVariable.c | 878 +++ > > > Platform/Intel/Tools/FCE/TimeBasedVariable.h | 166 + > > > Platform/Intel/Tools/FCE/Variable.c | 1091 +++ > > > Platform/Intel/Tools/FCE/Variable.h | 154 + > > > Platform/Intel/Tools/FCE/VariableCommon.h | 55 + > > > .../Tools/FMMT/FirmwareModuleManagement.c | 2559 +++++++ > > > .../Tools/FMMT/FirmwareModuleManagement.h | 479 ++ > > > Platform/Intel/Tools/FMMT/FmmtConf.ini | 6 + > > > Platform/Intel/Tools/FMMT/FmmtLib.c | 5051 > > > +++++++++++++ > > > Platform/Intel/Tools/FMMT/GNUmakefile | 16 + > > > Platform/Intel/Tools/FMMT/Makefile | 17 + > > > Platform/Intel/Tools/FMMT/Rebase.c | 846 +++ > > > Platform/Intel/Tools/FMMT/Rebase.h | 31 + > > > Platform/Intel/Tools/GNUmakefile | 30 + > > > Platform/Intel/Tools/Makefile | 33 + > > > Silicon/Intel/Tools/FitGen/FitGen.c | 3137 ++++++++ > > > Silicon/Intel/Tools/FitGen/FitGen.h | 48 + > > > Silicon/Intel/Tools/FitGen/GNUmakefile | 16 + > > > Silicon/Intel/Tools/FitGen/Makefile | 17 + > > > Silicon/Intel/Tools/GNUmakefile | 34 + > > > Silicon/Intel/Tools/Makefile | 31 + > > > 41 files changed, 41578 insertions(+) > > > create mode 100644 Platform/Intel/Tools/BfmLib/BfmLib.c > > > create mode 100644 Platform/Intel/Tools/BfmLib/BinFileManager.c > > > create mode 100644 Platform/Intel/Tools/BfmLib/BinFileManager.h > > > create mode 100644 Platform/Intel/Tools/BfmLib/GNUmakefile > > > create mode 100644 Platform/Intel/Tools/BfmLib/Makefile > > > create mode 100644 Platform/Intel/Tools/FCE/BinaryCreate.c > > > create mode 100644 Platform/Intel/Tools/FCE/BinaryCreate.h > > > create mode 100644 Platform/Intel/Tools/FCE/BinaryParse.c > > > create mode 100644 Platform/Intel/Tools/FCE/BinaryParse.h > > > create mode 100644 Platform/Intel/Tools/FCE/Common.c > > > create mode 100644 Platform/Intel/Tools/FCE/Common.h > > > create mode 100644 Platform/Intel/Tools/FCE/Expression.c > > > create mode 100644 Platform/Intel/Tools/FCE/Fce.c > > > create mode 100644 Platform/Intel/Tools/FCE/Fce.h > > > create mode 100644 Platform/Intel/Tools/FCE/GNUmakefile > > > create mode 100644 Platform/Intel/Tools/FCE/IfrParse.c > > > create mode 100644 Platform/Intel/Tools/FCE/IfrParse.h > > > create mode 100644 Platform/Intel/Tools/FCE/Makefile > > > create mode 100644 > Platform/Intel/Tools/FCE/MonotonicBasedVariable.c > > > create mode 100644 > Platform/Intel/Tools/FCE/MonotonicBasedVariable.h > > > create mode 100644 Platform/Intel/Tools/FCE/TimeBasedVariable.c > > > create mode 100644 Platform/Intel/Tools/FCE/TimeBasedVariable.h > > > create mode 100644 Platform/Intel/Tools/FCE/Variable.c > > > create mode 100644 Platform/Intel/Tools/FCE/Variable.h > > > create mode 100644 Platform/Intel/Tools/FCE/VariableCommon.h > > > create mode 100644 > > > Platform/Intel/Tools/FMMT/FirmwareModuleManagement.c > > > create mode 100644 > > > Platform/Intel/Tools/FMMT/FirmwareModuleManagement.h > > > create mode 100644 Platform/Intel/Tools/FMMT/FmmtConf.ini > > > create mode 100644 Platform/Intel/Tools/FMMT/FmmtLib.c > > > create mode 100644 Platform/Intel/Tools/FMMT/GNUmakefile > > > create mode 100644 Platform/Intel/Tools/FMMT/Makefile > > > create mode 100644 Platform/Intel/Tools/FMMT/Rebase.c > > > create mode 100644 Platform/Intel/Tools/FMMT/Rebase.h > > > create mode 100644 Platform/Intel/Tools/GNUmakefile > > > create mode 100644 Platform/Intel/Tools/Makefile > > > create mode 100644 Silicon/Intel/Tools/FitGen/FitGen.c > > > create mode 100644 Silicon/Intel/Tools/FitGen/FitGen.h > > > create mode 100644 Silicon/Intel/Tools/FitGen/GNUmakefile > > > create mode 100644 Silicon/Intel/Tools/FitGen/Makefile > > > create mode 100644 Silicon/Intel/Tools/GNUmakefile > > > create mode 100644 Silicon/Intel/Tools/Makefile > > > > > > -- > > > 2.18.0.windows.1 > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#42688): https://edk2.groups.io/g/devel/message/42688 Mute This Topic: https://groups.io/mt/32154333/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
