On 06/20/19 09:54, David Woodhouse wrote: > On Wed, 2019-06-19 at 03:19 -0400, Xiaoyu Lu wrote: >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1881 >> >> Commit(0a1b13fd4d2210e2c3) fix VS2017 build failure >> remove useless file in OpensslLib[Crypto].inf, >> but we use process_files.py to generate files. >> So exclude err_all.c file in process_files.py >> >> Cc: Jian J Wang <jian.j.w...@intel.com> >> Cc: Ting Ye <ting...@intel.com> >> Signed-off-by: Xiaoyu Lu <xiaoyux...@intel.com> >> --- >> CryptoPkg/Library/OpensslLib/process_files.pl | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/CryptoPkg/Library/OpensslLib/process_files.pl >> b/CryptoPkg/Library/OpensslLib/process_files.pl >> index e277108f0734..2783ff54f95a 100755 >> --- a/CryptoPkg/Library/OpensslLib/process_files.pl >> +++ b/CryptoPkg/Library/OpensslLib/process_files.pl >> @@ -132,6 +132,7 @@ foreach my $product ((@{$unified_info{libraries}}, >> # So it can reduce porting time, compile time, library size. >> next if $s =~ "crypto/rand/randfile.c"; >> next if $s =~ "crypto/store/"; >> + next if $s =~ "crypto/err/err_all.c"; >> >> if ($product =~ "libssl") { >> push @sslfilelist, ' $(OPENSSL_PATH)/' . $s . "\r\n"; >> -- > > Hm, this looks like the wrong approach to me. I only ever meant the > exclusions here to be a hack, to fix up things we couldn't properly do > in OpenSSL by disabling features. > > Now if you'd fixed up the crypto/store/ exclusion properly by prodding > Richard to add an OPENSSL_NO_STORE option, then the subsequent > inclusion of ERR_load_OSSL_STORE_strings() in err_all.c wouldn't have > led to further hacks to exclude *that* file... > > Please submit a PR to OpenSSL to add 'no-store' if you really don't > want it.
I actually agree about "no-store"; please see point (1) in my earlier review here: 0c5b5e95-cb2c-75af-a30b-015dac14b91c@redhat.com">http://mid.mail-archive.com/0c5b5e95-cb2c-75af-a30b-015dac14b91c@redhat.com But I've run out of steam on this -- especially the last weeks have seen me struggle with just reading my email. :( Thanks Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#42643): https://edk2.groups.io/g/devel/message/42643 Mute This Topic: https://groups.io/mt/32120631/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
