I am so sorry for my mistake. There are still ECC errors in the change of uni file. The additional string should be STR_gEfiMdeModulePkgTokenSpaceGuid_PcdPlatformRecoverySupport_PROMPT STR_gEfiMdeModulePkgTokenSpaceGuid_PcdPlatformRecoverySupport_HELP
I would update the patch. Thanks, Zhichao > -----Original Message----- > From: Ni, Ray > Sent: Wednesday, June 19, 2019 1:06 PM > To: Gao, Zhichao <zhichao....@intel.com>; devel@edk2.groups.io > Cc: Bret Barkelew <bret.barke...@microsoft.com>; Wang, Jian J > <jian.j.w...@intel.com>; Wu, Hao A <hao.a...@intel.com>; Zeng, Star > <star.z...@intel.com>; Gao, Liming <liming....@intel.com>; Sean Brogan > <sean.bro...@microsoft.com>; Michael Turner > <michael.tur...@microsoft.com> > Subject: RE: [PATCH V4 1/2] MdeModulePkg: Add a pcd to set the OS > indications bit > > Reviewed-by: Ray Ni <ray...@intel.com> > > > -----Original Message----- > > From: Gao, Zhichao > > Sent: Wednesday, June 19, 2019 11:10 AM > > To: devel@edk2.groups.io > > Cc: Bret Barkelew <bret.barke...@microsoft.com>; Wang, Jian J > > <jian.j.w...@intel.com>; Wu, Hao A <hao.a...@intel.com>; Ni, Ray > > <ray...@intel.com>; Zeng, Star <star.z...@intel.com>; Gao, Liming > > <liming....@intel.com>; Sean Brogan <sean.bro...@microsoft.com>; > > Michael Turner <michael.tur...@microsoft.com> > > Subject: [PATCH V4 1/2] MdeModulePkg: Add a pcd to set the OS > > indications bit > > > > From: Bret Barkelew <bret.barke...@microsoft.com> > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1678 > > > > Add a pcd PcdPlatformRecoverySupport to conditionally set an OS > > indications bit and set the 'PlatformRecovery####' > > variable. This pcd would also control whether the BDS support platform > > recovery or not. > > Update the uni file for description of the pcd. > > > > Cc: Jian J Wang <jian.j.w...@intel.com> > > Cc: Hao Wu <hao.a...@intel.com> > > Cc: Ray Ni <ray...@intel.com> > > Cc: Star Zeng <star.z...@intel.com> > > Cc: Liming Gao <liming....@intel.com> > > Cc: Sean Brogan <sean.bro...@microsoft.com> > > Cc: Michael Turner <michael.tur...@microsoft.com> > > Cc: Bret Barkelew <bret.barke...@microsoft.com> > > Signed-off-by: Zhichao Gao <zhichao....@intel.com> > > --- > > MdeModulePkg/MdeModulePkg.dec | 6 ++++++ > > MdeModulePkg/MdeModulePkg.uni | 2 ++ > > 2 files changed, 8 insertions(+) > > > > diff --git a/MdeModulePkg/MdeModulePkg.dec > > b/MdeModulePkg/MdeModulePkg.dec index 0a9fcddecc..da2b85770c > > 100644 > > --- a/MdeModulePkg/MdeModulePkg.dec > > +++ b/MdeModulePkg/MdeModulePkg.dec > > @@ -1660,6 +1660,12 @@ > > # @Prompt Reset on memory type information change. > > > > > gEfiMdeModulePkgTokenSpaceGuid.PcdResetOnMemoryTypeInformationC > h > > ange|TRUE|BOOLEAN|0x00010056 > > > > + ## Indicates if the BDS supports Platform Recovery.<BR><BR> > > + # TRUE - BDS supports Platform Recovery.<BR> > > + # FALSE - BDS does not support Platform Recovery.<BR> > > + # @Prompt Support Platform Recovery. > > + > > + > > > gEfiMdeModulePkgTokenSpaceGuid.PcdPlatformRecoverySupport|TRUE|B > O > > OLEAN > > + |0x00010078 > > + > > ## Specify the foreground color for Subtile text in HII Form > > Browser. The default value is EFI_BLUE. > > # Only following values defined in UEFI specification are valid:<BR><BR> > > # 0x00 (EFI_BLACK)<BR> > > diff --git a/MdeModulePkg/MdeModulePkg.uni > > b/MdeModulePkg/MdeModulePkg.uni index ed8ac9eadc..a265452eba > > 100644 > > --- a/MdeModulePkg/MdeModulePkg.uni > > +++ b/MdeModulePkg/MdeModulePkg.uni > > @@ -441,6 +441,8 @@ > > > > #string > > > STR_gEfiMdeModulePkgTokenSpaceGuid_PcdResetOnMemoryTypeInforma > ti > > onChange_PROMPT #language en-US "Reset on memory type information > > change" > > > > +#string > > > STR_gEfiMdeModulePkgTokenSpaceGuid_PcdResetOnMemoryTypeInforma > ti > > onChange #language en-US "Indicate the system support platform > > recovery or not" > > + > > #string > > > STR_gEfiMdeModulePkgTokenSpaceGuid_PcdResetOnMemoryTypeInforma > ti > > onChange_HELP #language en-US "Indicates if to reset system when > > memory type information changes.<BR><BR>\n" > > > > "TRUE - Resets system when memory type information changes.<BR>\n" > > > > "FALSE - Does not reset system when memory type information > changes.<BR>" > > -- > > 2.21.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#42618): https://edk2.groups.io/g/devel/message/42618 Mute This Topic: https://groups.io/mt/32119455/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-