> -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Laszlo > Ersek > Sent: Wednesday, June 12, 2019 3:58 PM > To: Wu, Hao A <hao.a...@intel.com>; Ni, Ray <ray...@intel.com>; David > Woodhouse <dw...@infradead.org>; Justen, Jordan L > <jordan.l.jus...@intel.com>; devel@edk2.groups.io > Cc: Ard Biesheuvel <ard.biesheu...@linaro.org>; Phillips, D Scott > <d.scott.phill...@intel.com> > Subject: Re: [edk2-devel] [PATCH v2 0/6] Ovmf: Drop > IntelFramework[Module]Pkg dependency > > Ray, > > On 06/12/19 04:13, Wu, Hao A wrote: > >> -----Original Message----- > >> From: Ni, Ray > >> Sent: Wednesday, June 12, 2019 10:04 AM > >> To: Wu, Hao A; David Woodhouse; Justen, Jordan L; > >> devel@edk2.groups.io > >> Cc: Laszlo Ersek; Ard Biesheuvel; Phillips, D Scott > >> Subject: RE: [PATCH v2 0/6] Ovmf: Drop IntelFramework[Module]Pkg > >> dependency > >> > >> Hao, > >> Will the CSM duplication cause any code change that may impact CSM > >> functionality? > > > > Hello Ray, > > > > I think there should be no functional impact for the duplication. > > There is no change to the .C/.H files. > > > > Best Regards, > > Hao Wu > > > >> If no, how about firstly duplicate them first? > >> > >> David, > >> Will this approach work for you? > > It will not work for me. > > Here's the problem: > > - I'm not comfortable approving the duplication (or move) under OvmfPkg, > until David ACKs the patch -- the first patch in the series -- that spells > out his > reviewership for the CSM modules, > > - I believe David is not comfortable ACKing that patch until he can get the > CSM build to work again.
I thought there is a dead lock but maybe not. I think the below things need to be done in order: 1. David gets the CSM build work again. 2. Hao sends out the patch to duplicate CSM in OvmfPkg. 3. David ACKs the patch 4. Hao pushes the patch. But when will #1 finish? I don't expect we stop here for a very long period. (I cannot remember when we started this conversation, maybe several months ago.) > > Thanks > Laszlo > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#42281): https://edk2.groups.io/g/devel/message/42281 Mute This Topic: https://groups.io/mt/32011839/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
