Reviewed-by: Eric Dong <eric.d...@intel.com> > -----Original Message----- > From: Ni, Ray > Sent: Wednesday, June 5, 2019 1:49 PM > To: devel@edk2.groups.io > Cc: Laszlo Ersek <ler...@redhat.com>; Dong, Eric <eric.d...@intel.com> > Subject: [PATCH v2 1/2] UefiCpuPkg/MpInitLib: increase NumApsExecuting > only for ApInitConfig > > NumApsExecuting is only used when InitFlag == ApInitConfig for counting the > processor count. > > The patch changes Ia32 version of waking up vector assembly code to align to > x64 version of waking up vector assembly code. > After the change both versions of waking up vector increase > NumApsExecuting when InitFlag == ApInitConfig. > > Signed-off-by: Ray Ni <ray...@intel.com> > Cc: Laszlo Ersek <ler...@redhat.com> > Cc: Eric Dong <eric.d...@intel.com> > --- > UefiCpuPkg/Library/MpInitLib/Ia32/MpFuncs.nasm | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/UefiCpuPkg/Library/MpInitLib/Ia32/MpFuncs.nasm > b/UefiCpuPkg/Library/MpInitLib/Ia32/MpFuncs.nasm > index 34b8705adb..b74046b76a 100644 > --- a/UefiCpuPkg/Library/MpInitLib/Ia32/MpFuncs.nasm > +++ b/UefiCpuPkg/Library/MpInitLib/Ia32/MpFuncs.nasm > @@ -1,5 +1,5 @@ > > ;------------------------------------------------------------------------------ > ; -; > Copyright (c) 2015 - 2018, Intel Corporation. All rights reserved.<BR> > +; Copyright (c) 2015 - 2019, Intel Corporation. All rights > +reserved.<BR> > ; SPDX-License-Identifier: BSD-2-Clause-Patent ; ; Module Name: > @@ -81,12 +81,6 @@ Flat32Start: ; protected > mode entry > point > > mov esi, ebx > > - ; Increment the number of APs executing here as early as possible > - ; This is decremented in C code when AP is finished executing > - mov edi, esi > - add edi, NumApsExecutingLocation > - lock inc dword [edi] > - > mov edi, esi > add edi, EnableExecuteDisableLocation > cmp byte [edi], 0 > @@ -120,6 +114,12 @@ SkipEnableExecuteDisable: > cmp dword [edi], 1 ; 1 == ApInitConfig > jnz GetApicId > > + ; Increment the number of APs executing here as early as possible > + ; This is decremented in C code when AP is finished executing > + mov edi, esi > + add edi, NumApsExecutingLocation > + lock inc dword [edi] > + > ; AP init > mov edi, esi > add edi, LockLocation > -- > 2.21.0.windows.1
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#42050): https://edk2.groups.io/g/devel/message/42050 Mute This Topic: https://groups.io/mt/31934505/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
