On Fri, 7 Jun 2019 at 15:11, Marcin Wojtas <m...@semihalf.com> wrote:
>
> Linux FWTS test of the ARM SBSA compliance suite
> fail on using unsupported _CID in UART node. Instead of
> removing, replace _HID to unique one ("MRVL0001") and
> match the driver via _CID ("HISI0031").
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Marcin Wojtas <m...@semihalf.com>

Reviewed-by: Ard Biesheuvel <ard.biesheu...@linaro.org>

Pushed as 1098e7ec3ee9..52f5e8d1abdf

> ---
> Changelog:
> v1->v2
> - Use "HISI0031" as _CID and change _HID to "MRVL0001"
> - Reflect the change in the commit message
>
>  Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Dsdt.asl    | 4 ++--
>  Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Dsdt.asl    | 4 ++--
>  Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl | 4 ++--
>  3 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Dsdt.asl 
> b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Dsdt.asl
> index 90b191b..5bac76a 100644
> --- a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Dsdt.asl
> +++ b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Dsdt.asl
> @@ -102,8 +102,8 @@ DefinitionBlock ("DSDT.aml", "DSDT", 2, "MVEBU ", 
> "ARMADA7K", 3)
>
>          Device (COM1)
>          {
> -            Name (_HID, "HISI0031")                             // _HID: 
> Hardware ID
> -            Name (_CID, "8250dw")                               // _CID: 
> Compatible ID
> +            Name (_HID, "MRVL0001")                             // _HID: 
> Hardware ID
> +            Name (_CID, "HISI0031")                             // _CID: 
> Compatible ID
>              Name (_ADR, FixedPcdGet64(PcdSerialRegisterBase))   // _ADR: 
> Address
>              Name (_CRS, ResourceTemplate ()                     // _CRS: 
> Current Resource Settings
>              {
> diff --git a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Dsdt.asl 
> b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Dsdt.asl
> index 5c060a3..e373d46 100644
> --- a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Dsdt.asl
> +++ b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Dsdt.asl
> @@ -146,8 +146,8 @@ DefinitionBlock ("DSDT.aml", "DSDT", 2, "MVEBU ", 
> "ARMADA8K", 3)
>
>          Device (COM1)
>          {
> -            Name (_HID, "HISI0031")                             // _HID: 
> Hardware ID
> -            Name (_CID, "8250dw")                               // _CID: 
> Compatible ID
> +            Name (_HID, "MRVL0001")                             // _HID: 
> Hardware ID
> +            Name (_CID, "HISI0031")                             // _CID: 
> Compatible ID
>              Name (_ADR, FixedPcdGet64(PcdSerialRegisterBase))   // _ADR: 
> Address
>              Name (_CRS, ResourceTemplate ()                     // _CRS: 
> Current Resource Settings
>              {
> diff --git a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl 
> b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl
> index f7cffb9..7e9e361 100644
> --- a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl
> +++ b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl
> @@ -145,8 +145,8 @@ DefinitionBlock ("DSDT.aml", "DSDT", 2, "MVEBU ", 
> "ARMADA8K", 3)
>
>          Device (COM1)
>          {
> -            Name (_HID, "HISI0031")                             // _HID: 
> Hardware ID
> -            Name (_CID, "8250dw")                               // _CID: 
> Compatible ID
> +            Name (_HID, "MRVL0001")                             // _HID: 
> Hardware ID
> +            Name (_CID, "HISI0031")                             // _CID: 
> Compatible ID
>              Name (_ADR, FixedPcdGet64(PcdSerialRegisterBase))   // _ADR: 
> Address
>              Name (_CRS, ResourceTemplate ()                     // _CRS: 
> Current Resource Settings
>              {
> --
> 2.7.4
>

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#42026): https://edk2.groups.io/g/devel/message/42026
Mute This Topic: https://groups.io/mt/31974500/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to