Push @0a1b13fd4d2210e2c379ace4fd961fb80126b7e9 > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Liming > Gao > Sent: Wednesday, June 5, 2019 8:23 AM > To: devel@edk2.groups.io; Wang, Jian J <jian.j.w...@intel.com> > Cc: Bi, Dandan <dandan...@intel.com>; Lu, XiaoyuX <xiaoyux...@intel.com> > Subject: Re: [edk2-devel] [PATCH] CryptoPkg/OpensslLib: fix VS2017 build > failure > > Reviewed-by: Liming Gao <liming....@intel.com> > > >-----Original Message----- > >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > >Wang, Jian J > >Sent: Wednesday, June 05, 2019 5:19 AM > >To: devel@edk2.groups.io > >Cc: Bi, Dandan <dandan...@intel.com>; Lu, XiaoyuX <xiaoyux...@intel.com> > >Subject: [edk2-devel] [PATCH] CryptoPkg/OpensslLib: fix VS2017 build failure > > > >BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1878 > > > >This issue is specific to VS2017 which tries to resolve symbol referenced > >by a symbol not really referenced eventually. > > > >ossl_init_load_crypto_strings > >-> err_load_crypto_strings_int (not really referenced) > >-> ERR_load_OSSL_STORE_strings > > > >Because OPENSSL_NO_ERR and OPENSSL_NO_AUTOERRINIT are not defined > >by > >default, err_load_crypto_strings_int() will not be actually referenced > >by ossl_init_load_crypto_strings(). > > > >Since err_load_crypto_strings_int() is not actually referenced at all, > >the fix can be done simply by removing crypto/err/err_all.c from build. > > > >Cc: Dandan Bi <dandan...@intel.com> > >Cc: Xiaoyu Lu <xiaoyux...@intel.com> > >Signed-off-by: Jian J Wang <jian.j.w...@intel.com> > >--- > > CryptoPkg/Library/OpensslLib/OpensslLib.inf | 1 - > > CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf | 1 - > > 2 files changed, 2 deletions(-) > > > >diff --git a/CryptoPkg/Library/OpensslLib/OpensslLib.inf > >b/CryptoPkg/Library/OpensslLib/OpensslLib.inf > >index 378fa6588e..5a2424fc16 100644 > >--- a/CryptoPkg/Library/OpensslLib/OpensslLib.inf > >+++ b/CryptoPkg/Library/OpensslLib/OpensslLib.inf > >@@ -218,7 +218,6 @@ > > $(OPENSSL_PATH)/crypto/dso/dso_win32.c > > $(OPENSSL_PATH)/crypto/ebcdic.c > > $(OPENSSL_PATH)/crypto/err/err.c > >- $(OPENSSL_PATH)/crypto/err/err_all.c > > $(OPENSSL_PATH)/crypto/err/err_prn.c > > $(OPENSSL_PATH)/crypto/evp/bio_b64.c > > $(OPENSSL_PATH)/crypto/evp/bio_enc.c > >diff --git a/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf > >b/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf > >index 24d3d96459..588da4c040 100644 > >--- a/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf > >+++ b/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf > >@@ -218,7 +218,6 @@ > > $(OPENSSL_PATH)/crypto/dso/dso_win32.c > > $(OPENSSL_PATH)/crypto/ebcdic.c > > $(OPENSSL_PATH)/crypto/err/err.c > >- $(OPENSSL_PATH)/crypto/err/err_all.c > > $(OPENSSL_PATH)/crypto/err/err_prn.c > > $(OPENSSL_PATH)/crypto/evp/bio_b64.c > > $(OPENSSL_PATH)/crypto/evp/bio_enc.c > >-- > >2.17.1.windows.2 > > > > > > > > >
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#41929): https://edk2.groups.io/g/devel/message/41929 Mute This Topic: https://groups.io/mt/31930984/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
