On Wed, 29 May 2019 at 13:37, Anthony PERARD <anthony.per...@citrix.com> wrote: > > The macro SERIAL_DXE_FILE_GUID is already been defined twice and the GUID is > been used once without defining the macro. This patch series define the macro > in MdeModulePkg where the SerialDxe is, and replace all other use by this new > one. > > Note that I haven't build/test those changes, but I have test the first patch > by applying a similar change to a patch series I'm working on. > > Patch series available in this git branch: > https://xenbits.xen.org/git-http/people/aperard/ovmf.git br.serial-dxe-guid-v1 > > Anthony PERARD (4): > MdeModulePkg: Add SERIAL_DXE_FILE_GUID > ArmVirtPkg/PlatformBootManagerLib: Use SERIAL_DXE_FILE_GUID from > MdeModulePkg > ArmPkg/PlatformBootManagerLib: Use SERIAL_DXE_FILE_GUID from > MdeModulePkg > UefiPayloadPkg/PlatformBootManagerLib: Use SERIAL_DXE_FILE_GUID from > MdeModulePkg > > MdeModulePkg/MdeModulePkg.dec | 3 +++ > MdeModulePkg/Include/Guid/SerialDxe.h | 19 +++++++++++++++++++ > .../PlatformBootManagerLib/PlatformBm.c | 6 +----- > .../PlatformBootManagerLib/PlatformBm.c | 6 +----- > .../PlatformBootManagerLib/PlatformConsole.c | 3 ++- > 5 files changed, 26 insertions(+), 11 deletions(-) > create mode 100644 MdeModulePkg/Include/Guid/SerialDxe.h >
Hello Anthony, If the MdeModulePkg maintainers are ok with this, then I'm fine with it as well. I would like to suggest to include a patch that does diff --git a/MdeModulePkg/Universal/SerialDxe/SerialDxe.inf b/MdeModulePkg/Universal/SerialDxe/SerialDxe.inf index 81066a26a278..761c2e6649de 100644 --- a/MdeModulePkg/Universal/SerialDxe/SerialDxe.inf +++ b/MdeModulePkg/Universal/SerialDxe/SerialDxe.inf @@ -11,7 +11,7 @@ INF_VERSION = 0x00010005 BASE_NAME = SerialDxe MODULE_UNI_FILE = SerialDxe.uni - FILE_GUID = D3987D4B-971A-435F-8CAF-4967EB627241 + FILE_GUID = D3987D4B-971A-435F-8CAF-4967EB627241 # SERIAL_DXE_FILE_GUID MODULE_TYPE = DXE_DRIVER VERSION_STRING = 1.0 so that it is clear for future users that there is a symbolic GUID constant they can use. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#41724): https://edk2.groups.io/g/devel/message/41724 Mute This Topic: https://groups.io/mt/31832613/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
