I just update the date of copyright. And the code in Mu project didn't add its own copyright. If it is required, I would add it for them. And I also make some minor changes on it.
Thanks, Zhichao > -----Original Message----- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Wednesday, May 29, 2019 7:12 PM > To: devel@edk2.groups.io; Gao, Zhichao <zhichao....@intel.com> > Cc: Bret Barkelew <bret.barke...@microsoft.com>; Wang, Jian J > <jian.j.w...@intel.com>; Wu, Hao A <hao.a...@intel.com>; Ni, Ray > <ray...@intel.com>; Zeng, Star <star.z...@intel.com>; Gao, Liming > <liming....@intel.com>; Sean Brogan <sean.bro...@microsoft.com>; > Michael Turner <michael.tur...@microsoft.com> > Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/CapsulePei: Optimize the > CapsulePei > > On Wed, May 29, 2019 at 08:45:55AM +0800, Gao, Zhichao wrote: > > From: Bret Barkelew <bret.barke...@microsoft.com> > > If this code is from Microsoft... > > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1853 > > > > Sperate the capsule check function from GetCapsuleDescriptors and name > > it to AreCapsulesStaged. > > Rename GetCapsuleDescriptors to GetScatterGatherHeadEntries. > > And optimize its to remove the duplicated code. > > > > Cc: Jian J Wang <jian.j.w...@intel.com> > > Cc: Hao A Wu <hao.a...@intel.com> > > Cc: Ray Ni <ray...@intel.com> > > Cc: Star Zeng <star.z...@intel.com> > > Cc: Liming Gao <liming....@intel.com> > > Cc: Sean Brogan <sean.bro...@microsoft.com> > > Cc: Michael Turner <michael.tur...@microsoft.com> > > Cc: Bret Barkelew <bret.barke...@microsoft.com> > > Signed-off-by: Zhichao gao <zhichao....@intel.com> > > --- > > MdeModulePkg/Universal/CapsulePei/Capsule.h | 3 +- > > .../Universal/CapsulePei/CapsulePei.inf | 3 +- > > .../Universal/CapsulePei/UefiCapsule.c | 357 ++++++++++-------- > > 3 files changed, 194 insertions(+), 169 deletions(-) > > > > diff --git a/MdeModulePkg/Universal/CapsulePei/Capsule.h > > b/MdeModulePkg/Universal/CapsulePei/Capsule.h > > index baf40423af..fc20dd8b92 100644 > > --- a/MdeModulePkg/Universal/CapsulePei/Capsule.h > > +++ b/MdeModulePkg/Universal/CapsulePei/Capsule.h > > @@ -1,6 +1,6 @@ > > /** @file > > > > -Copyright (c) 2006 - 2018, Intel Corporation. All rights > > reserved.<BR> > > +Copyright (c) 2006 - 2019, Intel Corporation. All rights > > +reserved.<BR> > > > > SPDX-License-Identifier: BSD-2-Clause-Patent > > > > @@ -30,6 +30,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > > #include <Library/PcdLib.h> #include <Library/ReportStatusCodeLib.h> > > #include <Library/DebugAgentLib.h> > > +#include <Library/MemoryAllocationLib.h> > > #include <IndustryStandard/PeImage.h> #include > > "Common/CommonHeader.h" > > > > diff --git a/MdeModulePkg/Universal/CapsulePei/CapsulePei.inf > > b/MdeModulePkg/Universal/CapsulePei/CapsulePei.inf > > index 5d43df3075..9c88b3986f 100644 > > --- a/MdeModulePkg/Universal/CapsulePei/CapsulePei.inf > > +++ b/MdeModulePkg/Universal/CapsulePei/CapsulePei.inf > > @@ -6,7 +6,7 @@ > > # This external input must be validated carefully to avoid security > > issue like # buffer overflow, integer overflow. > > # > > -# Copyright (c) 2006 - 2018, Intel Corporation. All rights > > reserved.<BR> > > +# Copyright (c) 2006 - 2019, Intel Corporation. All rights > > +reserved.<BR> > > ...why does Intel get the copyright? > > / > Leif -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#41621): https://edk2.groups.io/g/devel/message/41621 Mute This Topic: https://groups.io/mt/31828852/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
