On 05/09/19 05:03, Wu, Hao A wrote: >> -----Original Message----- >> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Dong, >> Eric >> Sent: Wednesday, May 08, 2019 11:02 AM >> To: devel@edk2.groups.io >> Cc: Wu, Hao A >> Subject: [edk2-devel] [Patch v2 1/3] SecurityPkg/SecurityPkg.dec: Change >> default value. > > Just one minor comment, how about changing the title to: > SecurityPkg/SecurityPkg.dec: Change BlockSID default policy
That's an improvement too, thanks. Laszlo > > Other than that, the patch is good to me: > Reviewed-by: Hao A Wu <hao.a...@intel.com> > > Best Regards, > Hao Wu > >> >> https://bugzilla.tianocore.org/show_bug.cgi?id=1782 >> >> Change BlockSID default policy, default enable BlockSid. >> >> Signed-off-by: Eric Dong <eric.d...@intel.com> >> Cc: Hao Wu <hao.a...@intel.com> >> --- >> SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h | 3 ++- >> SecurityPkg/SecurityPkg.dec | 2 +- >> 2 files changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h >> b/SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h >> index d9eee7f3e8..8da3deaf86 100644 >> --- a/SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h >> +++ b/SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h >> @@ -51,7 +51,8 @@ SPDX-License-Identifier: BSD-2-Clause-Patent >> // Default value >> // >> #define TCG2_BIOS_STORAGE_MANAGEMENT_FLAG_DEFAULT >> (TCG2_BIOS_STORAGE_MANAGEMENT_FLAG_PP_REQUIRED_FOR_ENABLE_BL >> OCK_SID | \ >> - >> TCG2_BIOS_STORAGE_MANAGEMENT_FLAG_PP_REQUIRED_FOR_DISABLE_BL >> OCK_SID) >> + >> TCG2_BIOS_STORAGE_MANAGEMENT_FLAG_PP_REQUIRED_FOR_DISABLE_BL >> OCK_SID |\ >> + >> TCG2_BIOS_STORAGE_MANAGEMENT_FLAG_ENABLE_BLOCK_SID) >> >> /** >> Check and execute the pending TPM request. >> diff --git a/SecurityPkg/SecurityPkg.dec b/SecurityPkg/SecurityPkg.dec >> index 6e4c4c3a02..3314f1854b 100644 >> --- a/SecurityPkg/SecurityPkg.dec >> +++ b/SecurityPkg/SecurityPkg.dec >> @@ -410,7 +410,7 @@ >> # PCD can be configured for different settings in different scenarios >> # Default setting is TCG2_BIOS_TPM_MANAGEMENT_FLAG_DEFAULT | >> TCG2_BIOS_STORAGE_MANAGEMENT_FLAG_DEFAULT >> # @Prompt Initial setting of TCG2 Persistent Firmware Management Flags >> - >> gEfiSecurityPkgTokenSpaceGuid.PcdTcg2PhysicalPresenceFlags|0x300E2|UINT3 >> 2|0x0001001B >> + >> gEfiSecurityPkgTokenSpaceGuid.PcdTcg2PhysicalPresenceFlags|0x700E2|UINT3 >> 2|0x0001001B >> >> ## Indicate current TPM2 Interrupt Number reported by _CRS control >> method.<BR><BR> >> # TPM2 Interrupt feature is disabled If the pcd is set to 0.<BR> >> -- >> 2.21.0.windows.1 >> >> >> > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#40330): https://edk2.groups.io/g/devel/message/40330 Mute This Topic: https://groups.io/mt/31539610/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-