This brings up a question? Do we tests on a file system that is case sensitive? Is this just lack of a test case?
Thanks, Andrew Fish > On May 6, 2019, at 7:22 PM, Fan, ZhijuX <zhijux....@intel.com> wrote: > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1773 > > Build break if C file suffixes of named .C instead of .c > Code not recognize filenames with .C suffixes. > > This patch adds code to Support both .c file and .C file > > Cc: Bob Feng <bob.c.f...@intel.com> > Cc: Liming Gao <liming....@intel.com> > Signed-off-by: Zhiju.Fan <zhijux....@intel.com> > --- > BaseTools/Source/Python/AutoGen/GenMake.py | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/BaseTools/Source/Python/AutoGen/GenMake.py > b/BaseTools/Source/Python/AutoGen/GenMake.py > index 0e0f9fd9b0..858ddedf8e 100644 > --- a/BaseTools/Source/Python/AutoGen/GenMake.py > +++ b/BaseTools/Source/Python/AutoGen/GenMake.py > @@ -1035,7 +1035,8 @@ cleanlib: > CmdTargetDict[CmdSign] = "%s %s" % > (CmdTargetDict[CmdSign], SingleCommandList[-1]) > Index = CommandList.index(Item) > CommandList.pop(Index) > - if SingleCommandList[-1].endswith("%s%s.c" % (TAB_SLASH, > CmdSumDict[CmdSign.lstrip('/Fo').rsplit(TAB_SLASH, 1)[0]])): > + if SingleCommandList[-1].endswith("%s%s.c" % (TAB_SLASH, > CmdSumDict[T.Target.SubDir])) or \ > + SingleCommandList[-1].endswith("%s%s.C" % > (TAB_SLASH, CmdSumDict[T.Target.SubDir])): > Cpplist = CmdCppDict[T.Target.SubDir] > Cpplist.insert(0, '$(OBJLIST_%d): $(COMMON_DEPS)' % > list(self.ObjTargetDict.keys()).index(T.Target.SubDir)) > T.Commands[Index] = '%s\n\t%s' % (' > \\\n\t'.join(Cpplist), CmdTargetDict[CmdSign]) > -- > 2.14.1.windows.1 > > > > > <winmail.dat> -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#40064): https://edk2.groups.io/g/devel/message/40064 Mute This Topic: https://groups.io/mt/31527775/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
