On 04/25/19 22:52, Kinney, Michael D wrote: > SafeIntLib demonstrates a unit test that runs without any > user input and verifies the result of each unit test and > provides test results in a standard format. > > The OrderedCollectionLibTest provides a way for a developer > to manually test that lib class or generate a file from a > Linux specific script with a set of commands to run from > an input file. However, I do not see any functionality in > this test app to verify the results. It appears to depend > on a developer manually inspecting the output. > > Given that OrderedCollectionLibTest appears to be a manual > test requiring interaction, and since effort was made to > implement this interactive utility, I would recommend this > remain in AppPkg in the edk2-libc repo so it is still > available for that use case.
OK. > As we enable automated unit tests in edk2, we can implement > a new automated unit test for the OrderedCollectionLib class. > > Please see the following thread and branch for some ideas on > unit tests: > > https://edk2.groups.io/g/devel/message/39439 > > https://github.com/tengfens/edk2-staging/tree/HBFA > > I agree that writing unit tests must be made as simple as > possible for developers to encourage everyone to implement > and submit unit tests for new content. I look forward to > your feedback on that thread. I have to be honest here: I've skimmed the above references, and I won't be able to give them the attention they deserve. :( Thanks, Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#39659): https://edk2.groups.io/g/devel/message/39659 Mute This Topic: https://groups.io/mt/31251207/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
