The change is good. And, please update the patch based on the latest trunk.
Reviewed-by: Liming Gao <liming....@intel.com> Thanks Liming > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Zhang, > Shenglei > Sent: Tuesday, April 9, 2019 11:21 AM > To: devel@edk2.groups.io > Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Feng, Bob C > <bob.c.f...@intel.com>; Gao, Liming <liming....@intel.com>; Zhu, > Yonghong <yonghong....@intel.com> > Subject: [edk2-devel] [PATCH 0/3] Remove ICC tool chain > > There is no Intel complier test. So suggest to remove ICC > tool chain from tools_def.template and remove support of Intel > tool chain in BaseLib. And also IoLibIcc.c > in MdePkg should update to be removed. > https://bugzilla.tianocore.org/show_bug.cgi?id=1666 > > Cc: Michael D Kinney <michael.d.kin...@intel.com> > Cc: Bob Feng <bob.c.f...@intel.com> > Cc: Liming Gao <liming....@intel.com> > Cc: Yonghong Zhu <yonghong....@intel.com> > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Shenglei Zhang <shenglei.zh...@intel.com> > Shenglei Zhang (3): > MdePkg/BaseIoLibIntrinsic: Remove IoLibIcc.c > MdePkg/BaseLib: Remove support of INTEL tool chain > BaseTools: Remove ICC tool chain in tools_def.template > > BaseTools/Conf/tools_def.template | 1092 ----------------- > .../BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf | 2 - > .../BaseIoLibIntrinsicSev.inf | 2 - > MdePkg/Library/BaseIoLibIntrinsic/IoLibIcc.c | 214 ---- > MdePkg/Library/BaseLib/BaseLib.inf | 196 +-- > 5 files changed, 7 insertions(+), 1499 deletions(-) > delete mode 100644 MdePkg/Library/BaseIoLibIntrinsic/IoLibIcc.c > > -- > 2.18.0.windows.1 > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#39401): https://edk2.groups.io/g/devel/message/39401 Mute This Topic: https://groups.io/mt/30995499/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
