Reviewed by Qian, Yi<yi.q...@intel.com>

Thanks
Qian Yi

-----Original Message-----
From: Sun, Zailiang 
Sent: Wednesday, April 17, 2019 5:21 PM
To: devel@edk2.groups.io
Cc: Wei, David <david....@intel.com>; Qian, Yi <yi.q...@intel.com>
Subject: [PATCH] Vlv2TbltDevicePkg: Remove ResetSystem declaration

Use MdeModulePkg declaration of ResetSystem function, comment the one in 
platform source code.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zailiang Sun <zailiang....@intel.com>
Cc: David Wei <david....@intel.com>
Cc: Yi Qian <yi.q...@intel.com>
---
 Vlv2TbltDevicePkg/PlatformPei/Platform.c |  1 -  
Vlv2TbltDevicePkg/PlatformPei/Platform.h | 12 +++++++-----
 2 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/Vlv2TbltDevicePkg/PlatformPei/Platform.c 
b/Vlv2TbltDevicePkg/PlatformPei/Platform.c
index cf47a56a52..eba1dfff30 100644
--- a/Vlv2TbltDevicePkg/PlatformPei/Platform.c
+++ b/Vlv2TbltDevicePkg/PlatformPei/Platform.c
@@ -18,7 +18,6 @@ Module Name:
 #include "PlatformBaseAddresses.h"
 #include "PchAccess.h"
 #include <Guid/PlatformInfo.h>
-#include "Platform.h"
 #include "PchCommonDefinitions.h"
 #include <Ppi/MfgMemoryTest.h>
 #include <Guid/SetupVariable.h>
diff --git a/Vlv2TbltDevicePkg/PlatformPei/Platform.h 
b/Vlv2TbltDevicePkg/PlatformPei/Platform.h
index 4158dd4cf5..e1817b28c6 100644
--- a/Vlv2TbltDevicePkg/PlatformPei/Platform.h
+++ b/Vlv2TbltDevicePkg/PlatformPei/Platform.h
@@ -47,16 +47,18 @@ UpdateBootMode (
 /**
   This function reset the entire platform, including all processor and 
devices, and
   reboots the system.
+
+  Declaration of this function goes to 
+ MdeModulePkg/Include/Library/ResetSystemLib.h
 
   @param  PeiServices General purpose services available to every PEIM.
 
   @retval EFI_SUCCESS if it completed successfully.
 **/
-EFI_STATUS
-EFIAPI
-ResetSystem (
-  IN CONST EFI_PEI_SERVICES          **PeiServices
-  );
+// EFI_STATUS
+// EFIAPI
+// ResetSystem (
+  // IN CONST EFI_PEI_SERVICES          **PeiServices
+  // );
 
 /**
   This function will be called when MRC is done.
--
2.19.1.windows.1



-- 
Qian Yi

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#39283): https://edk2.groups.io/g/devel/message/39283
Mute This Topic: https://groups.io/mt/31209989/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to