On 04/11/19 22:11, Philippe Mathieu-Daudé wrote: > On 4/11/19 9:58 PM, Rebecca Cran wrote: >> On 2019-04-11 13:55, Philippe Mathieu-Daudé wrote: >>> >>> With the work around link added: >>> Reviewed-by: Philippe Mathieu-Daude <phi...@redhat.com> >> >> >> >> But it's _not_ working around that bug. That was about "uname -p", but >> the patch is about "uname -m".
That sounds convincing, thank you for the clarification. I'd still say it's a workaround, just not for that specific FreeBSD BZ, because: > Ah you are right, the script simply parse the 'machine hardware name' to > extract the host architecture. We shouldn't rely on the 'processor type > name' which is non-portable. obviously the "machine hardware name" is non-portable either, when we consider FreeBSD. Either way I've obsessed enough about this. Reviewed-by: Laszlo Ersek <ler...@redhat.com> Thanks Laszlo > Simply checking for 'arm64' is enough. > > So do not add the link, and keep my tag: > Reviewed-by: Philippe Mathieu-Daude <phi...@redhat.com> -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#38945): https://edk2.groups.io/g/devel/message/38945 Mute This Topic: https://groups.io/mt/31026994/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
