Laszlo, I am doing these before the license change to resolve PatchCheck.py issues in the license change patch series.
I will rebase before commit. Mike > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] > On Behalf Of Laszlo Ersek > Sent: Thursday, April 4, 2019 5:53 AM > To: devel@edk2.groups.io; Kinney, Michael D > <michael.d.kin...@intel.com> > Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> > Subject: Re: [edk2-devel] [Patch 3/4] ArmVirtPkg: > Normalize line endings to CRLF > > On 04/04/19 00:00, Michael D Kinney wrote: > > https://bugzilla.tianocore.org/show_bug.cgi?id=1659 > > > > Normalize line endings to use CRLF to pass > PatchCheck.py > > > > Cc: Laszlo Ersek <ler...@redhat.com> > > Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> > > Contributed-under: TianoCore Contribution Agreement > 1.1 > > Signed-off-by: Michael D Kinney > <michael.d.kin...@intel.com> > > --- > > ArmVirtPkg/Include/Platform/Hidden.h | 56 > ++++++++++++++-------------- > > 1 file changed, 28 insertions(+), 28 deletions(-) > > > > diff --git a/ArmVirtPkg/Include/Platform/Hidden.h > b/ArmVirtPkg/Include/Platform/Hidden.h > > index fbd3467471..997866ff50 100644 > > --- a/ArmVirtPkg/Include/Platform/Hidden.h > > +++ b/ArmVirtPkg/Include/Platform/Hidden.h > > @@ -1,28 +1,28 @@ > > -/** @file > > - > > - Copyright (c) 2018, Linaro Limited. All rights > reserved. > > - > > - This program and the accompanying materials > > - are licensed and made available under the terms and > conditions of the BSD License > > - which accompanies this distribution. The full text > of the license may be found at > > - http://opensource.org/licenses/bsd-license.php > > - > > - THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON > AN "AS IS" BASIS, > > - WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, > EITHER EXPRESS OR IMPLIED. > > - > > -**/ > > - > > -#ifndef __PLATFORM_HIDDEN_H > > -#define __PLATFORM_HIDDEN_H > > - > > -// > > -// Setting the GCC -fvisibility=hidden command line > option is not quite the same > > -// as setting the pragma below: the former only > affects definitions, whereas the > > -// pragma affects extern declarations as well. So if > we want to ensure that no > > -// GOT indirected symbol references are emitted, we > need to use the pragma, or > > -// GOT based cross object references could be > emitted, e.g., in libraries, and > > -// these cannot be relaxed to ordinary symbol > references at link time. > > -// > > -#pragma GCC visibility push (hidden) > > - > > -#endif > > +/** @file > > + > > + Copyright (c) 2018, Linaro Limited. All rights > reserved. > > + > > + This program and the accompanying materials > > + are licensed and made available under the terms and > conditions of the BSD License > > + which accompanies this distribution. The full text > of the license may be found at > > + http://opensource.org/licenses/bsd-license.php > > + > > + THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON > AN "AS IS" BASIS, > > + WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, > EITHER EXPRESS OR IMPLIED. > > + > > +**/ > > + > > +#ifndef __PLATFORM_HIDDEN_H > > +#define __PLATFORM_HIDDEN_H > > + > > +// > > +// Setting the GCC -fvisibility=hidden command line > option is not quite the same > > +// as setting the pragma below: the former only > affects definitions, whereas the > > +// pragma affects extern declarations as well. So if > we want to ensure that no > > +// GOT indirected symbol references are emitted, we > need to use the pragma, or > > +// GOT based cross object references could be > emitted, e.g., in libraries, and > > +// these cannot be relaxed to ordinary symbol > references at link time. > > +// > > +#pragma GCC visibility push (hidden) > > + > > +#endif > > > > This will conflict with the license conversion, so I > suggest redoing > this patch after the conversion is pushed. > > Other than that, > > Acked-by: Laszlo Ersek <ler...@redhat.com> > > Thanks > Laszlo > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#74): https://edk2.groups.io/g/devel/message/74 Mute This Topic: https://groups.io/mt/30886238/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
