GitHub user khalidhuseynov opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/900
Refactor CORS filter into webapp context handler
### What is this PR for?
#867 was a hotfix and merged immediately. However we can refactor CORS
filter into more appropriate place, which is webapp context handler instead of
keeping it in rest api handler (since it also applies to websocket api).
### What type of PR is it?
Refactoring
### Todos
* [x] - move from rest to webapp
### What is the Jira issue?
### How should this be tested?
Basically this is refactoring, and original flow holds.
For testing, can use same routine as in #867.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/khalidhuseynov/incubator-zeppelin
fix/refactor-cors-filter
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/900.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #900
----
commit 210a61328fdc586080db15b3bcdf49fbae7a2ae4
Author: Khalid Huseynov <khalid...@nflabs.com>
Date: 2016-05-19T02:42:43Z
move cors filter from rest api to webapp handler
cors filter doesn't apply only to rest api but also to websocket api, so
general webapp context would be more correct
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
