GitHub user prabhjyotsingh opened a pull request:

    https://github.com/apache/incubator-zeppelin/pull/881

    ZEPPELIN-844: Navbar menu should not show up if user is not authenticated

    ### What is this PR for?
    If a user in not authenticated, s/he should not see Navbar menu, or search 
bar, or import/create note book links.
    
    ### What type of PR is it?
    [Bug Fix]
    
    ### Todos
    * [x] - Hide all option from frontend
    
    ### What is the Jira issue?
    [ZEPPELIN-844](https://issues.apache.org/jira/browse/ZEPPELIN-844)
    
    ### How should this be tested?
    Change shiro conf to enable authentication. Now when home page is loaded 
you should not see any of the Navbar menu or option to create or import notebook
    
    ### Screenshots (if appropriate)
    Before:
    <img width="1439" alt="screen shot 2016-05-10 at 3 08 10 pm" 
src="https://cloud.githubusercontent.com/assets/674497/15142088/1918535c-16c1-11e6-9c2e-2662fdfb90e6.png";>
    
    After:
    <img width="1440" alt="screen shot 2016-05-10 at 2 49 05 pm" 
src="https://cloud.githubusercontent.com/assets/674497/15142087/19183778-16c1-11e6-896e-1dc708c8700b.png";>
    
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no 
    * Does this needs documentation? no 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/prabhjyotsingh/incubator-zeppelin ZEPPELIN-844

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-zeppelin/pull/881.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #881
    
----
commit 032be217f9a0da202167d8d88f7cac3311c98918
Author: Prabhjyot Singh <prabhjyotsi...@gmail.com>
Date:   2016-05-10T09:32:21Z

    ZEPPELIN-844: Navbar menu should not show up if user is not authenticated.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to