GitHub user FRosner opened a pull request:

    https://github.com/apache/incubator-zeppelin/pull/844

    ZEPPELIN-815 don't create a sub shell for the runner

    ### What is this PR for?
    
    This pull request is supposed to fix ZEPPELIN-815. The issue is that one 
cannot stop Zeppelin by sending a signal, because it starts the runner in a sub 
shell. The pull request starts the runner in the same process as the 
`zeppelin.sh`, making it react to signals.
    
    ### What type of PR is it?
    
    Improvement
    
    ### Todos
    
    * [ ] - Task
    
    ### What is the Jira issue?
    
    https://issues.apache.org/jira/browse/ZEPPELIN-815
    
    ### How should this be tested?
    - Start `zeppelin.sh`
    - Get PID of the `zeppelin.sh` process
    - Send SIGINT (`kill -SIGINT <pid>`) to the `zeppelin.sh` process
    - Observe that Zeppelin is stopped
    
    ### Screenshots
    
    none
    
    ### Questions:
    * What is the reason to put an exec into a sub shell in the first place?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/FRosner/incubator-zeppelin ZEPPELIN-815

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-zeppelin/pull/844.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #844
    
----

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to