Github user ankurmitujjain commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/761#issuecomment-208277805
@corneadoug I believe with above suggested changes it seems that you want
this PR to replace default table implementation with data-tables only...
So current PR will be without search and download/export buttons.
My main motive for this PR was to provide download button to download data
in csv or tsv format. :P
Also you wanted to remove floatHead dependency which got added by #565
with default datatable scrollbar.
Note: floatHead is to make table headers fixed, datatable alternative to
this is FixedHeader
For scrolling current implementation is using perfect-scrollbar .
Please correct me if my understanding is wrong :P
After going to datatables site it seems that default scrollbar of datatable
needs fix "y" size , after doing a round of testing it seems, when we change
paragraph size table will not get updated/redrawn automatically, so we will
need some kind of tweak around to get that fixed or basically redraw table.
[Datatable default
Scroll](https://datatables.net/examples/basic_init/scroll_xy.html)
I also saw a scroller and fixedheader plugin of datatable which implements
scrolling over default scrollbar, but it seems that perfectScrollbar with
floatHead is good alternative over those as I feel their UI is better and
provide mu more functionality over these plugins...
[floathead](http://mkoryak.github.io/floatThead/datatables/)
[perfect-scrollbar](https://github.com/noraesae/perfect-scrollbar)
For other points..
- the search bar is unnecessary in non-table case
I will remove search box for now, but I was thinking to dynamically update
charts on filtered dataset with that searchbox (may be another PR).
- It doesn't download the pivoted data (doesn't really matter)
- Hard to resize
Please share me steps /screenshots for above.
Please feel free to add any kind of changes to my PR, I would welcome good
changes, as I like to have features added to zeppelin ASAP instead of thinking
for credit/contribution sharing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
