GitHub user AhyoungRyu opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/738
Enable user to change shell interpreter command timeout property
### What is this PR for?
Although Shell Interpreter has already have [command timeout
property](https://github.com/apache/incubator-zeppelin/blob/master/shell/src/main/java/org/apache/zeppelin/shell/ShellInterpreter.java#L49),
users can not change this property via Zeppelin UI. So I added some code lines
to `ShellInterpreter.java` so that users can change this value at the
interpreter setting tab.
### What type of PR is it?
Improvement
### Todos
* [x] - Enable user to change shell interpreter command timeout property
* [x] - Fix a dead link in `interpreter.java`
### Is there a relevant Jira issue?
Nope
### How should this be tested?
After applying this PR, you can make `%sh` interpreter at the Zeppelin
interpreter setting section.
1. Change `shell.command.timeout.millisecs` 600000(default value) -> 5000
so that you can check quickly
2. Run
* **Success Case**
```
%sh
date && sleep 3 && date
```
then you can get a result as below
```
Mon Feb 22 18:25:00 KST 2016
Mon Feb 22 18:25:03 KST 2016
ExitValue: 143
```
* **Error Case(because of timeout property)**
```
%sh
date && sleep 6 && date
```
then you can get a result as below
```
Mon Feb 22 18:25:00 KST 2016
Paragraph received a SIGTERM.
ExitValue: 143
```
### Screenshots (if appropriate)
**Before**
**After**
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/AhyoungRyu/incubator-zeppelin shell-timeout
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/738.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #738
----
commit b16211dc4bc9bbda714a0f87245025781599fd3f
Author: AhyoungRyu <[email protected]>
Date: 2016-02-22T09:36:05Z
Enable user to change shell interpreter timeout property
commit 3b4faec18b4e2ddb18a271272fc8828f5e438205
Author: AhyoungRyu <[email protected]>
Date: 2016-02-22T09:37:28Z
Fix reference link in interpreter.java
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
