Github user cloverhearts commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/580#issuecomment-167936450
@corneadoug
I have a question. I will try to fix the node as your opinion.
However, there is two thing that troubled part.
1. The proposed codes are who you appear to be implemented in
websocketEvents.factory.js.
But I think the websocketEvents.factory.js only raise the event. I think
such actions will redirect websocketEvents.factory.js not happen, not later be
processed in a dependency problem Controller.js to handle it.
2. NEW-NOTE, and CLONE_NOTE, suggesting it unifies the event as NEW_NOTE Is
modify server-side code?
I respect the opinion of the @corneadoug.
Thank you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
