Hi!
On Mon, Nov 30, 2015 at 10:33 PM, moon soo Lee <[email protected]> wrote:
> Hi Cos,
>
> Thanks for opening a discussion.
> My answer about 'Why this PR is open for three months' is
>
> 1. This PR does not passes CI
> 2. Not 100% sure this PR has no license issue. (about KniteR)
> 3. Need more time to review.
After inspecting both implementation AND the bundle I'd like
to render my mentor AND an ASF member opinion here: the
PR (as implemented on 5th of December 2015) clearly does
NOT have any licensing issues. Thus, I'd like this discussion
between Zeppelin community and Amos to ONLY focus on
resolving #1 and #3. To me this is definitely a loop that needs
to be closed before we start any kind of serious conversation
around graduation.
For the curious ones, here's the basis for my opinion. First of all,
the dependency on R itself is mediated by the
org.apache.zeppelin.rinterpreter.rscala.RClient
implementation that is clearly treating R as a self-contained
external process thus avoiding GPL implications. All the
communications are done via a network protocol over
sockets.
Second of all, a further dependency on knitr is mediated by
explicitly NOT automating the step of installing it, but rather
reporting to the user that it needs to be installed via the means
that R package management provides:
https://github.com/apache/incubator-zeppelin/pull/208/files#diff-1b1779bbf782da9507bacc3396ab6676R297
Thanks,
Roman.
