Github user corneadoug commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/312#issuecomment-144314720
  
    I saw a few more improvements possible:
    * Since we are setting a new config option: 
``paragraph.config.graph.lineWithFocus`` doing a new graphMode is not necessary 
(it would even remove a lot of code not to do it)
    * One problem with having ``lineWithFocus`` and ``forceY`` set in 
``paragraph.config.graph`` is that when we change the graph type, those options 
are still there. The best would be to add them into 
``paragraph.config.graph.options`` and clear that ``options`` object when we 
change graph


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to