Github user zenglinxi0615 commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/319#issuecomment-143938382
@Leemoonsoo
Thanks for your advice!
I think it's hard to make a decision, making broadcast() and
broadcastAll() waits for message being sent by each threads before return can
guarantee message delivery order to the websocket connection, but it will risk
to block the notebook server send messege to new websocket connection because
of the synchronized (connectedSockets) when there is a bad websocket
connection in list, which will lead a bad influence of user experience.
So the key thing here is that is it necessary to guarantee message delivery
order to the websocket connectionï¼ and why?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
