Github user tzolov commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/206#issuecomment-138292992
  
    Thanks for the update @corneadoug. I've faced the ace upgrade issue while 
preparing the (ZEPPELIN-216).  When i tried to upgrade ace to 1.2.0 the 
existing ui-ace version complained. I've managed to increase ui-ace but had to 
force some dependency resolutions and was not confident it will not cause side 
effects. So i upgraded ace to safest ace 1.1.9 version instead. But if you 
manage to upgrade ui-ace (very outdated it seems) it will allow us upgrade 
ace-build as well. 
    Also i would still love to learn how to write angular controller unit 
tests. 
    
    @Leemoonsoo , @felixcheung it seems that this PR (e.g. ZEPPELIN-219) is 
ready to merge.
    The tests will come after the ui-ace upgrade.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to