GitHub user corneadoug opened a pull request:

    https://github.com/apache/incubator-zeppelin/pull/245

    Fix NotebookList Ordering

    In the notebook list, the notebooks that have been created without name 
(empty name) and prefixed with 'Note' are not ordered correctly with the others.
    
    The reason behind it, is that when notebook doesn't have a name, we use the 
notebook id and prefix it by 'Note'. At that time the list was already ordered 
and therefore the Name shown doesn't match the position in the list.
    
    Before:
    ![screen shot 2015-08-22 at 2 48 56 
pm](https://cloud.githubusercontent.com/assets/710411/9422740/f9d7a496-48dc-11e5-9326-bfddd16dd66d.png)
    
    After:
    ![screen shot 2015-08-22 at 2 30 26 
pm](https://cloud.githubusercontent.com/assets/710411/9422688/6fdc69f4-48da-11e5-8f39-5752369942ab.png)
    
    The Fix I have is to have an ordering function at the place we prefix the 
'Note' on the front side.
    Another solution could be to just to have by default the notebook name as 
'Note ' + note.id when we create a note. The second option could probably be 
better performance wise, however it wouldn't be backward compatible.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/corneadoug/incubator-zeppelin 
fix/NotebookListOrder

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-zeppelin/pull/245.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #245
    
----
commit d899184920240eed05db43a449bc9ad15829f254
Author: Damien Corneau <cornead...@gmail.com>
Date:   2015-08-22T04:29:54Z

    Add ordering service and order notebook list

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to